Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Groonga 5.1.2 and 6.0.0 #116

Open
13 of 16 tasks
myokoym opened this issue Feb 28, 2016 · 18 comments · May be fixed by #172
Open
13 of 16 tasks

Support Groonga 5.1.2 and 6.0.0 #116

myokoym opened this issue Feb 28, 2016 · 18 comments · May be fixed by #172

Comments

@myokoym
Copy link
Member

myokoym commented Feb 28, 2016

Added APIs

5.1.2

  • grn_hash_size()
  • GRN_HASH_TINY
  • grn_dump_table_create_flags()
  • grn_dump_column_create_flags()
  • grn_plugin_get_names()
  • grn_column_get_all_index_data()
  • grn_config_get() (renamed from grn_conf_get())
  • grn_config_set() (renamed from grn_conf_set())
  • grn_config_delete()
  • grn_config_cursor_open()
  • grn_config_cursor_next()
  • grn_config_cursor_get_key()
  • grn_config_cursor_get_value()
  • GRN_CURSOR_CONFIG
  • grn_get_global_error_message()

6.0.0

  • grn_pat_fuzzy_search()
  • grn_table_fuzzy_search()
  • GRN_OP_FUZZY
  • GRN_TABLE_FUZZY_SEARCH_WITH_TRANSPOSITION
  • GRN_TOKENIZE_ONLY
  • grn_obj_type_to_string()
  • grn_expr_syntax_expand_query()
@kou
Copy link
Member

kou commented Mar 1, 2016

Needless APIs:

5.1.2

  • grn_hash_size()
  • GRN_HASH_TINY
  • grn_dump_table_create_flags()
  • grn_dump_column_create_flags()

6.0.0

  • grn_pat_fuzzy_search()
  • GRN_TABLE_FUZZY_SEARCH_WITH_TRANSPOSITION

@myokoym
Copy link
Member Author

myokoym commented Mar 1, 2016

Thanks! First, I'll try to bind grn_hash_size().

@myokoym
Copy link
Member Author

myokoym commented Mar 1, 2016

Groonga::Hash has #size as Groonga::Table#size.
grn_hash_size() is already used in grn_table_size().

@myokoym
Copy link
Member Author

myokoym commented Mar 1, 2016

Groonga::Hash has #size as Groonga::Table#size.
grn_hash_size() is already used in grn_table_size().

Should we call grn_hash_size() directly in Groonga::Hash?

@kou
Copy link
Member

kou commented Mar 2, 2016

I listed "needless" API.

You should not bind grn_hash_size().

@myokoym
Copy link
Member Author

myokoym commented Mar 2, 2016

Oh... I was wrong. I understand "needless".

@myokoym myokoym mentioned this issue Mar 2, 2016
14 tasks
myokoym pushed a commit that referenced this issue Mar 5, 2016
myokoym pushed a commit that referenced this issue Mar 5, 2016
myokoym pushed a commit that referenced this issue Mar 5, 2016
GitHub: #116

TODO: Add multiple indexes test.
myokoym pushed a commit that referenced this issue Mar 5, 2016
To bind the following functions:

  * grn_config_cursor_open()
  * grn_config_cursor_next()
  * grn_config_cursor_get_key()
  * grn_config_cursor_get_value()

GitHub: #116
myokoym pushed a commit that referenced this issue Mar 5, 2016
myokoym pushed a commit that referenced this issue Mar 5, 2016
@myokoym
Copy link
Member Author

myokoym commented Mar 5, 2016

grn_table_fuzzy_search()

よく見たら外部には公開されていなかった。

myokoym pushed a commit that referenced this issue Mar 5, 2016
@myokoym
Copy link
Member Author

myokoym commented Mar 6, 2016

GRN_TOKENIZE_ONLY

I don't know how to bind for users...

@myokoym
Copy link
Member Author

myokoym commented Mar 6, 2016

grn_expr_syntax_expand_query()

It's difficult for me... A draft API that I thougt:

users.select(query_expander: "Thesaurus.synonym") do |record|

Note: http://groonga.org/ja/docs/reference/commands/select.html#query-expander

@cosmo0920
Copy link
Member

I don't know

FYI: "I don't know ..." sounds negligent.
We should use "I have no idea how ...."

@kou
Copy link
Member

kou commented Mar 6, 2016

GRN_TOKENIZE_ONLY

I don't know how to bind for users...

We skip to bind it in this release.

@kou
Copy link
Member

kou commented Mar 6, 2016

grn_expr_syntax_expand_query()

It's difficult for me... A draft API that I thougt:

It should be Groonga::Query.expand(query, expander, :flags => 0). But we have no time...
We skip to bind it in this release... We should do it in the next release...
We should also bind grn_expr_syntax_escape_query() in the next release.

@myokoym
Copy link
Member Author

myokoym commented Mar 6, 2016

We skip to bind it in this release.

It should be Groonga::Query.expand(query, expander, :flags => 0). But we have no time...
We skip to bind it in this release... We should do it in the next release...
We should also bind grn_expr_syntax_escape_query() in the next release.

I understand. I'm writing the 6.0.0 release entry.

@myokoym
Copy link
Member Author

myokoym commented Mar 6, 2016

FYI: "I don't know ..." sounds negligent.
We should use "I have no idea how ...."

Thanks!

@cosmo0920
Copy link
Member

Can we close this? Rroonga 6.0.0 has already released.

@myokoym
Copy link
Member Author

myokoym commented Mar 26, 2016

I think we can't close this issue because some items will be supported in the next release.

@komainu8 komainu8 linked a pull request Aug 19, 2019 that will close this issue
@komainu8
Copy link
Member

Is GRN_TOKENIZE_ONLY use by Groonga user?
I have no idea how to use this flag.
Could you teach me how to use it?

@kou
Copy link
Member

kou commented Aug 26, 2019

If we use GRN_TOKENIZE_ONLY is used, token isn't register to lexicon.
We can get tokens without modifying lexicon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants