Bind grn_config_delete() #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: #116
| assert_equal("value", context.config["rroonga.key"]) | ||
| context.config.delete("rroonga.key") | ||
| assert do | ||
| not context.config["rroonga.key"] |
There was a problem hiding this comment.
Why is it not assert_nil(context.config["rroonga.key"])?
There was a problem hiding this comment.
勘違いしました。
真偽値のチェックにはassert do 〜 endを使うべきと思っていましたが、
ここはnilかどうかなので真偽値ではないですね。修正します。
added 2 commits
March 5, 2016 12:54
kou
added a commit
that referenced
this pull request
Mar 5, 2016
Bind grn_config_delete() Patch by Masafumi Yokoyama. Thanks!!!
|
Thanks! |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #116