Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require UCX 1.14.0+ #27

Closed
jakirkham opened this issue Mar 6, 2024 · 4 comments · Fixed by rapidsai/raft#2227
Closed

Require UCX 1.14.0+ #27

jakirkham opened this issue Mar 6, 2024 · 4 comments · Fixed by rapidsai/raft#2227

Comments

@jakirkham
Copy link
Member

Recently we dropped libnuma from RAPIDS Docker images: rapidsai/miniforge-cuda#22 (comment)

The libnuma dependency is added to conda-forge's ucx packages starting in 1.14.0: conda-forge/ucx-split-feedstock#111

To ensure libnuma is available, we should make sure that ucx is 1.14.0 or newer. Some potential places to update

@pentschev
Copy link
Member

Given all packages listed depend on UCX-Py, we should anyway be covered for conda: https://github.com/rapidsai/ucx-py/blob/50532d099d564659a8f98043a0164ed49cd30f95/conda/recipes/ucx-py/meta.yaml#L38 .

I think we should just use UCX-Py (and UCXX in the future) as ground truth for UCX version, this prevents us from having to update all other projects. For that I agree we have to update dependencies.yaml in the UCX-Py/UCXX repos, but what I'm observing is that doing so does not update cbc/meta.yaml when committing, do you know why that happens @jakirkham ?

@jakirkham
Copy link
Member Author

As long as they are not using UCX directly, agree with that proposal. Seems easier to implement

The conda-builds changes need to be made manually

If we want rapidsai-dependency-file-generator to do this for us, would recommend raising a new issue

@vyasr
Copy link
Contributor

vyasr commented Mar 8, 2024

Please double-check existing issues before raising new ones. In this case, what you want is in rapidsai/dependency-file-generator#7

@bdice
Copy link
Contributor

bdice commented Mar 14, 2024

As of rapidsai/ucx-py#1032 and rapidsai/ucxx#205, the ucx version pinning in RAPIDS has been updated to 1.15 and libnuma has been dropped.

I opened rapidsai/integration#704 and rapidsai/raft#2227, which should be enough to close this issue.

rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Mar 14, 2024
As of rapidsai/ucx-py#1032 and rapidsai/ucxx#205, the `ucx` version pinning in RAPIDS has been updated. This PR aligns with those changes.

Closes rapidsai/build-planning#27.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - https://github.com/jakirkham

URL: #2227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants