-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support meta.yaml, pyproject.toml and versions.json #7
Comments
The PR below was opened to adjust the |
We now support writing out pyproject.toml files. I will open a separate thread to discuss issues with supporting meta.yaml files. |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this issue
Jul 31, 2024
…4582) @caryr35 pointed out to me this morning that `cugraph`'s nightly CI is failing. All `conda-python-build` jobs are failing like this, when building `nx-cugraph` > ModuleNotFoundError: No module named 'setuptools' > ... > ValueError: Could not import build backend specified in pyproject.toml's tool.rapids-build-backend table. Make sure you specified the right optional dependency in your build-system.requires entry for rapids-build-backend. ([build link](https://github.com/rapidsai/cugraph/actions/runs/10176436224/job/28166520972)) **suspected root cause:** `nx-cugraph` uses `setuptools.build_meta`, but `setuptools` isn't present in the conda build environment ## Notes for Reviewers ### Why is this targeting `branch-24.08`? Looks like CI is failing there too: https://github.com/rapidsai/cugraph/actions/runs/10183681336/job/28171285190 ### Why is this just breaking now? I suspect that prior to this we were getting `setuptools` because it was a transitive dependency of one of `nx-cugraph`'s other build/host dependencies. ### How could we prevent stuff like this in the future? We could add support for updating conda recipe files in `rapids-dependency-file-generator` (rapidsai/dependency-file-generator#7). `setuptools` was correctly added as a build dependency in `pyproject.toml` files here (automatically, via `dependencies.yaml` + `rapids-dependency-file-generator`), but the conda recipe `meta.yaml` files were missed. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Bradley Dice (https://github.com/bdice) - Rick Ratzel (https://github.com/rlratzel) URL: #4582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In addition to conda requirements files, the rapid dependency generator needs to support a few additional use cases. In order of priority, these are:
Enabling the above will require making the following changes (in roughly this order based on which tasks depend on others as well as their relative priorities):
conda_and_requirements
key as the way to specify requirements that are common to both types of dependency files. Instead of this, we will need to modify the file to have something like afile_types
key that accepts an array of values and writes those requirements to all the associated files. That would allow one set of entries to be shared across an arbitrary subset of different files.rapids_cpm_load_preset_versions
into a separate function.Some additional notes and caveats:
$PKG=$VERSION
rather than$PKG>x,<y
etc.The text was updated successfully, but these errors were encountered: