Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies.yaml Schema #11

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Oct 24, 2022

This PR updates the dependencies.yaml schema to help ensure compatibility with future output file types.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This schema change looks great to me.

@ajschmidt8 ajschmidt8 added the breaking Introduces a breaking change label Oct 24, 2022
@vyasr
Copy link
Contributor

vyasr commented Oct 24, 2022

Same here, the schema changes look like what we discussed! Let us know if you run into snags updating the code to generate this.

@ajschmidt8 ajschmidt8 force-pushed the change-schema branch 2 times, most recently from f701a1d to 03a87be Compare October 24, 2022 20:05
ajschmidt8 added a commit to ajschmidt8/rmm that referenced this pull request Oct 24, 2022
This PR updates the `dependencies.yaml` schema in anticipation of rapidsai/dependency-file-generator#11 being merged.
@ajschmidt8 ajschmidt8 marked this pull request as ready for review October 24, 2022 20:41
@ajschmidt8 ajschmidt8 requested review from bdice and vyasr October 24, 2022 20:41
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly re-reviewed the new changes. Looks good.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@ajschmidt8 ajschmidt8 merged commit ecec4b1 into rapidsai:main Oct 25, 2022
@ajschmidt8 ajschmidt8 deleted the change-schema branch October 25, 2022 18:53
ajschmidt8 added a commit to ajschmidt8/rmm that referenced this pull request Oct 25, 2022
This PR updates the `dependencies.yaml` schema in anticipation of rapidsai/dependency-file-generator#11 being merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants