add 'wheel' to ci-wheel image #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
changed the title
bdice
approved these changes
Dec 3, 2024
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Dec 9, 2024
We're now pre-installing `wheel` in the CI images: rapidsai/ci-imgs#215 This proposes removing a `pip install wheel` in CI here... fewer network requests = fewer random CI failures 😁 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138
Proposes installing
wheelin theci-wheelimages, to remove the need to install it at build time on every CI run for header-only C++ wheel builds, likelibrmmdoes:python -m pip install wheel python -m wheel tags --platform any dist/* --remove(rmm/ci/build_wheel.sh)