Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop installing 'wheel' in wheel-building script #1748

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

jameslamb
Copy link
Member

Description

We're now pre-installing wheel in the CI images: rapidsai/ci-imgs#215

This proposes removing a pip install wheel in CI here... fewer network requests = fewer random CI failures 😁

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 5, 2024
Copy link

copy-pr-bot bot commented Dec 5, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@github-actions github-actions bot added the ci label Dec 5, 2024
@jameslamb jameslamb changed the title WIP: stop installing 'wheel' in wheel-building script stop installing 'wheel' in wheel-building script Dec 5, 2024
@jameslamb jameslamb marked this pull request as ready for review December 5, 2024 18:55
@jameslamb jameslamb requested a review from a team as a code owner December 5, 2024 18:55
@jameslamb jameslamb requested a review from msarahan December 5, 2024 18:55
@jameslamb
Copy link
Member Author

This is ready for review. The pre-commit.ci job failure is a result of the testing happening in #1746

@bdice
Copy link
Contributor

bdice commented Dec 9, 2024

#1746 is fixed up and merged. This should be mergeable without the upstream though, so I’ll trigger it.

@bdice
Copy link
Contributor

bdice commented Dec 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit ff59ea4 into rapidsai:branch-25.02 Dec 9, 2024
59 of 61 checks passed
@jameslamb jameslamb deleted the remove-wheel-install branch December 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants