-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] click
is listed only in test requirements but is a required in order to use cucim.clara
#703
Comments
click
is listed only in test requirements but is a requirement in order to use cucim.clara
click
is listed only in test requirements but is a required in order to use cucim.clara
Thanks Greg! 🙏 We should also consider adding a test that tries |
Currently this is just in test requirements cucim/python/cucim/pyproject.toml Lines 57 to 60 in eee3e4c
The Conda package already makes this a cucim/conda/recipes/cucim/meta.yaml Lines 70 to 76 in eee3e4c
|
Fixes #703 Trying to `import cucim` results in `import click`, which fails if `click` is not installed. This was encountered recently by a user that tested out the cuCIM wheel packages. The Conda packages already solve this by adding `click` to `requirements/run`. So this makes an equivalent change to the wheel packages. Should fix user install issues. Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) - Gigon Bae (https://github.com/gigony) - Ray Douglass (https://github.com/raydouglass) URL: #719
Describe the bug
click
should not be required unless the CLIconvert
tool based on it is used.Steps/Code to reproduce bug
@drbeh reported that
pip
installing the recent PyPI release of 24.02 and then tryingresults in
Expected behavior
It is possible to use
cucim.clara
classes other than theconvert
command-line utility ifclick
is not installed.Environment details (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: