Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] click is listed only in test requirements but is a required in order to use cucim.clara #703

Closed
grlee77 opened this issue Feb 23, 2024 · 2 comments · Fixed by #719
Closed
Labels
bug Something isn't working
Milestone

Comments

@grlee77
Copy link
Contributor

grlee77 commented Feb 23, 2024

Describe the bug
click should not be required unless the CLI convert tool based on it is used.

Steps/Code to reproduce bug

@drbeh reported that pip installing the recent PyPI release of 24.02 and then trying

from cucim import CuImage

results in

ModuleNotFoundError: No module named 'click'

Expected behavior
It is possible to use cucim.clara classes other than the convert command-line utility if click is not installed.

Environment details (please complete the following information):

Additional context

@grlee77 grlee77 added the bug Something isn't working label Feb 23, 2024
@grlee77 grlee77 added this to the v24.04.00 milestone Feb 23, 2024
@grlee77 grlee77 added this to cucim Feb 23, 2024
@grlee77 grlee77 changed the title [BUG] click is listed only in test requirements but is a requirement in order to use cucim.clara [BUG] click is listed only in test requirements but is a required in order to use cucim.clara Feb 23, 2024
@jakirkham
Copy link
Member

Thanks Greg! 🙏

We should also consider adding a test that tries imports without the test dependencies installed. This could flag similar issues for us in the future

@jakirkham
Copy link
Member

jakirkham commented Apr 2, 2024

Currently this is just in test requirements

[project.optional-dependencies]
test = [
"GPUtil>=1.4.0",
"click",

The Conda package already makes this a requirement/run

run:
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
{% if cuda_major != "11" %}
- cuda-cudart
{% endif %}
- {{ pin_compatible('numpy') }}
- click

@rapids-bot rapids-bot bot closed this as completed in #719 Apr 2, 2024
rapids-bot bot pushed a commit that referenced this issue Apr 2, 2024
Fixes #703

Trying to `import cucim` results in `import click`, which fails if `click` is not installed. This was encountered recently by a user that tested out the cuCIM wheel packages.

The Conda packages already solve this by adding `click` to `requirements/run`. So this makes an equivalent change to the wheel packages.

Should fix user install issues.

Authors:
  - https://github.com/jakirkham

Approvers:
  - Gregory Lee (https://github.com/grlee77)
  - Gigon Bae (https://github.com/gigony)
  - Ray Douglass (https://github.com/raydouglass)

URL: #719
@github-project-automation github-project-automation bot moved this to Done in cucim Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants