Require click as a wheel dependency
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
bug
Trying to `import cucim` results in `import click`, which fails if `click` is not installed. This was encountered recently by a user that tested out the cuCIM wheel packages. The Conda packages already solve this by adding `click` to `requirements/run`. So this makes an equivalent change to the wheel packages. Should fix user install issues.
jakirkham
force-pushed
the
req_click_run_whl
branch
from
99cc26f to
4bfbb0e
Compare
grlee77
approved these changes
Apr 2, 2024
gigony
approved these changes
Apr 2, 2024
raydouglass
approved these changes
Apr 2, 2024
|
/merge |
|
Ran into a network error in one job. Mentioned in this upstream issue ( conda/infrastructure#906 (comment) ). Have also restarted it |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703
Trying to
import cucimresults inimport click, which fails ifclickis not installed. This was encountered recently by a user that tested out the cuCIM wheel packages.The Conda packages already solve this by adding
clicktorequirements/run. So this makes an equivalent change to the wheel packages.Should fix user install issues.