Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Forward-merge branch-22.08 to branch-22.10 [skip gpuci] #391

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-22.08 that creates a PR to keep branch-22.10 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

@GPUtester
Copy link
Contributor Author

FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/gpuci/#forward-mergers
IMPORTANT: Before merging and approving this PR, be sure to change the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

closes #392

This PR fixes #392 and also makes it more friendly for use with user-provided `block_params`. In general, most users should not be providing that argument, but it can be used to compare different settings for performance optimization. In case of user-provided `block_params`, the implementation now automatically pad the shape to an appropriate least common multiple of the warp_size and the `m1`, `m2` and `m3` block parameters.

More extensive unit tests over a range of image sizes and `block_params` settings are now implemented.

Authors:
   - Gregory Lee (https://github.com/grlee77)

Approvers:
   - Gigon Bae (https://github.com/gigony)
   - https://github.com/jakirkham
@jakirkham
Copy link
Member

Fixing conflicts in PR ( #403 )

@ajschmidt8 ajschmidt8 merged commit cd5deb8 into branch-22.10 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants