Forward-merge branch-22.08 to branch-22.10 [skip gpuci] #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idsai#393) closes rapidsai#392 This PR fixes rapidsai#392 and also makes it more friendly for use with user-provided `block_params`. In general, most users should not be providing that argument, but it can be used to compare different settings for performance optimization. In case of user-provided `block_params`, the implementation now automatically pad the shape to an appropriate least common multiple of the warp_size and the `m1`, `m2` and `m3` block parameters. More extensive unit tests over a range of image sizes and `block_params` settings are now implemented. Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham
jakirkham
added
bug
|
cc @rapidsai/ops-codeowners |
ajschmidt8
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conflicts with the bot generated forward-merger ( #391 ).