Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Testing arrow seg fault #17022

Closed
wants to merge 14 commits into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 8, 2024

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

wence- added 9 commits October 1, 2024 16:07
Everything in the expression evaluation now operates on columns
without names. DataFrame construction takes either a mapping from
string-valued names to columns, or a sequence of pairs of names and
columns.

This removes some duplicate code in the NamedColumn class (by removing
it) where we had to fight the inheritance hierarchy.

- Closes rapidsai#16272
Rather than separating names from columns with tuple return values in
IR evaluation, allow columns to optionally have names that are copied
around. When we construct a dataframe from columns we now must assert
that the column has a name, but otherwise this is OK.
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 8, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Oct 28, 2024

I'm going to close this as it's gone as far as we need to take it. See apache/arrow#44342 and jemalloc/jemalloc#2739 for more info.

@vyasr vyasr closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants