Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronization bug in bool parquet mukernels #17302

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

pmattione-nvidia
Copy link
Contributor

@pmattione-nvidia pmattione-nvidia commented Nov 12, 2024

This fixes a synchronization bug in the parquet microkernels for plain-decoding bools. This closes several timing issues found during testing of spark-rapids.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 12, 2024
@pmattione-nvidia pmattione-nvidia changed the title add sync Fix synchronization bug in bool parquet mukernels Nov 12, 2024
@pmattione-nvidia pmattione-nvidia added ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 12, 2024
@pmattione-nvidia pmattione-nvidia marked this pull request as ready for review November 12, 2024 22:19
@pmattione-nvidia pmattione-nvidia requested a review from a team as a code owner November 12, 2024 22:19
@pmattione-nvidia
Copy link
Contributor Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] parquet_testing_test.py failed on "AssertionError: GPU and CPU boolean values are different"
3 participants