Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronization bug in bool parquet mukernels #17302

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix synchronization bug in bool parquet mukernels #17302

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ecb071
add sync
pmattione-nvidia Nov 12, 2024
a7fffba
Merge branch 'branch-24.12' into mukernel_bools_fix
pmattione-nvidia Nov 12, 2024
f61430c
style fix
pmattione-nvidia Nov 12, 2024
0d7c856
Merge branch 'mukernel_bools_fix' of https://github.com/pmattione-nvi…
pmattione-nvidia Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/io/parquet/decode_fixed.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ inline __device__ void bool_plain_decode(page_state_s* s, state_buf* sb, int t,
{
int pos = s->dict_pos;
int const target_pos = pos + to_decode;
__syncthreads(); // Make sure all threads have read dict_pos before it changes at the end.

while (pos < target_pos) {
int const batch_len = min(target_pos - pos, decode_block_size_t);
Expand Down
Loading