Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix literal zero cuda_stream_view argument in JNI [skip ci] #7972

Merged
merged 2 commits into from
Apr 15, 2021
Merged

fix literal zero cuda_stream_view argument in JNI [skip ci] #7972

merged 2 commits into from
Apr 15, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Apr 15, 2021

Eliminates literal zero arguments to cuda_stream_view parameters in libcudfjni, replacing them with rmm::cuda_stream_default

Followup to rapidsai/rmm#740

CC @harrism

@rongou rongou added bug Something isn't working 3 - Ready for Review Ready for review by team RMM ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Apr 15, 2021
@rongou rongou requested review from jlowe and revans2 April 15, 2021 18:19
@rongou rongou requested a review from a team as a code owner April 15, 2021 18:19
@rongou rongou self-assigned this Apr 15, 2021
@jlowe jlowe changed the title fix literal zero cuda_stream_view argument in jni [skip ci] fix literal zero cuda_stream_view argument in JNI [skip ci] Apr 15, 2021
@rongou
Copy link
Contributor Author

rongou commented Apr 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 29ad7c6 into rapidsai:branch-0.20 Apr 15, 2021
@rongou rongou deleted the fix-jni-cuda-stream-view branch November 23, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2

Assignees

@rongou rongou

Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongou @jlowe