Disable construction of cuda_stream_view from literal zero or nullptr #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
3 - Ready for review
jrhemstad
approved these changes
Mar 31, 2021
rongou
approved these changes
Mar 31, 2021
|
rerun tests |
|
Merge after rapidsai/cudf/#7774 |
harrism
added
5 - Ready to Merge
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Apr 8, 2021
Eliminates literal zero arguments to `cuda_stream_view` parameters in libcudf, replacing them with `rmm::cuda_stream_default` Followup to rapidsai/rmm#740 Authors: - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mike Wilson (https://github.com/hyperbolic2346) - Jake Hemstad (https://github.com/jrhemstad) - MithunR (https://github.com/mythrocks) URL: #7774
|
@gpucibot merge |
This was referenced Apr 15, 2021
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Apr 15, 2021
Eliminates literal zero arguments to `cuda_stream_view` parameters in libcudfjni, replacing them with `rmm::cuda_stream_default` Followup to rapidsai/rmm#740 CC @harrism Authors: - Rong Ou (https://github.com/rongou) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #7972
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Apr 15, 2021
Updates necessary due to rapidsai/rmm#740. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: #384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the
rmm::cuda_stream_viewconstructors fromintandnullptr_tto disable construction from literal zero ornullptr. This makes stream parameters harder to misuse and more strongly types stream parameters in RAPIDS APIs.This is a breaking change that will more than likely require corresponding changes in dependent RAPIDS libraries.