Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PASCAL #4022

Closed
ChuckHastings opened this issue Nov 27, 2023 · 1 comment · Fixed by #4044
Closed

Drop support for PASCAL #4022

ChuckHastings opened this issue Nov 27, 2023 · 1 comment · Fixed by #4044
Assignees
@ChuckHastings

Comments

@ChuckHastings
Copy link
Collaborator

RAPIDS is dropping support for PASCAL in release 24.02. There are a collection of places in the C++ code where we check at runtime to see if we're executing on PASCAL and change the behavior (e.g. raise an exception, run a different code path).

We should review the code (I think it's all Louvain related) and drop all of the extra code for supporting PASCAL.
@ChuckHastings
Copy link
Collaborator Author

A list of files where we left FIXME for these issues:

  • tests/community/louvain_test.cpp
  • tests/community/ecg_test.cpp
  • tests/community/leiden_test.cpp
  • tests/structure/coarsen_graph_test.cpp

@ChuckHastings ChuckHastings mentioned this issue Dec 5, 2023
Merged
@ChuckHastings ChuckHastings self-assigned this Dec 5, 2023
rapids-bot bot pushed a commit that referenced this issue Dec 13, 2023
@ChuckHastings
Remove checks for Pascal, no longer supported (#4044)
5890d80 
The only remaining "support" for Pascal was a check that if we're on a Pascal GPU we expect the function to throw an exception.  Not sure it does anymore (don't see evidence of it, we haven't tested on Pascal for a long time), but if we're not supporting Pascal it doesn't matter.

Closes #4022

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove checks for Pascal, no longer supported ChuckHastings/cugraph
1 participant
@ChuckHastings