Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for Pascal, no longer supported #4044

Merged

Conversation

ChuckHastings
Copy link
Collaborator

The only remaining "support" for Pascal was a check that if we're on a Pascal GPU we expect the function to throw an exception. Not sure it does anymore (don't see evidence of it, we haven't tested on Pascal for a long time), but if we're not supporting Pascal it doesn't matter.

Closes #4022

@ChuckHastings ChuckHastings self-assigned this Dec 5, 2023
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cuGraph labels Dec 5, 2023
@ChuckHastings ChuckHastings marked this pull request as ready for review December 5, 2023 20:09
@ChuckHastings ChuckHastings requested a review from a team as a code owner December 5, 2023 20:09
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seunghwak
Copy link
Contributor

We should update this as well.

set(supported_archs "60" "62" "70" "72" "75" "80" "86" "89" "90")

Pascal is no longer supported

@ChuckHastings ChuckHastings requested a review from a team as a code owner December 5, 2023 20:32
@github-actions github-actions bot added doc Documentation cuGraph CMake labels Dec 5, 2023
@ChuckHastings
Copy link
Collaborator Author

We should update this as well.

set(supported_archs "60" "62" "70" "72" "75" "80" "86" "89" "90")

Pascal is no longer supported

Dropped 60 and 62 from supported architecture list

@ChuckHastings ChuckHastings removed the doc Documentation label Dec 5, 2023
@rlratzel
Copy link
Contributor

rlratzel commented Dec 6, 2023

Should this PR also remove the various Pascal checks from the CI scripts, like here and here?

@ChuckHastings ChuckHastings requested a review from a team as a code owner December 6, 2023 17:10
@github-actions github-actions bot added the ci label Dec 6, 2023
@ChuckHastings
Copy link
Collaborator Author

Should this PR also remove the various Pascal checks from the CI scripts, like here and here?

I believe so. Fixed in latest push.

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 5890d80 into rapidsai:branch-24.02 Dec 13, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for PASCAL
4 participants