-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace device_memory_resource* with device_async_resource_ref #4333
Closed
Labels
improvement
Improvement / enhancement to an existing function
Comments
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 24, 2024
Closes #4333 For reviewers: Many of changes are simple textual replace of `rmm::mr::device_memory_resource *` with `rmm::device_async_resource_ref`. However, I found that `concurrent_unordered_map` used in cuGraph is not up to date with the latest changes from the version in libcudf, so I copied those over as well. This gets rid of the `hash_allocator.cuh`, and uses `rmm::mr::polymorphic_allocator` instead of the custom allocator previously used. This obviates the need to update any `device_memory_resource*` used in the old custom allocator. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) URL: #4365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update occurences of
rmm::mr::device_memory_resource*
tormm::device_async_resource_ref
in this repo. The rationale is explainedin this document.
The text was updated successfully, but these errors were encountered: