Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert device_memory_resource* to device_async_resource_ref #4365

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Apr 23, 2024

Closes #4333

For reviewers:
Many of changes are simple textual replace of rmm::mr::device_memory_resource * with rmm::device_async_resource_ref.

However, I found that concurrent_unordered_map used in cuGraph is not up to date with the
latest changes from the version in libcudf, so I copied those over as well. This gets rid
of the hash_allocator.cuh, and uses rmm::mr::polymorphic_allocator instead of the custom
allocator previously used. This obviates the need to update any device_memory_resource* used
in the old custom allocator.

@github-actions github-actions bot removed the python label Apr 23, 2024
@harrism harrism added improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 23, 2024
@harrism harrism marked this pull request as ready for review April 23, 2024 01:41
@harrism harrism requested a review from a team as a code owner April 23, 2024 01:41
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harrism !

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 3393b06 into rapidsai:branch-24.06 Apr 24, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cuGraph improvement Improvement / enhancement to an existing function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace device_memory_resource* with device_async_resource_ref
2 participants