Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add degrees to C API #4212

Merged
merged 27 commits into from
Mar 12, 2024
Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Mar 4, 2024

Add new method cugraph_degrees to the C API to compute and return the degrees of vertices.

Closes #4171

@ChuckHastings ChuckHastings self-assigned this Mar 4, 2024
rlratzel
rlratzel previously approved these changes Mar 7, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Mar 7, 2024

This LGTM. I'm fine if we want to add the remaining updates needed to PLC, then the updates to the MG python code all to this PR if it's easier.

@rlratzel rlratzel dismissed their stale review March 7, 2024 19:55

Approved too soon - I'll re-review and approve when this is out of Draft and the remaining updates are added.

@github-actions github-actions bot added the python label Mar 9, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review March 11, 2024 16:20
@ChuckHastings ChuckHastings requested review from a team as code owners March 11, 2024 16:20
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (C/C++ part)

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only reviewed the python code and I have a few requests and questions.

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit fdc6aa5 into rapidsai:branch-24.04 Mar 12, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: degree, in_degree, and out_degree Returns Double Values for MG Graphs
5 participants