Skip to content

Commit

Permalink
[REVIEW] deleting prims and updating paths (#3067)
Browse files Browse the repository at this point in the history
* deleting prims and updating paths

* changelog

* style check

* pinning RAFT to latest commit

* style checks

* likely fixing conda builds

* correcting option in cpu ci build

* removing testing label
  • Loading branch information
divyegala authored Oct 31, 2020
1 parent 30644b4 commit 7e6d413
Show file tree
Hide file tree
Showing 349 changed files with 884 additions and 12,083 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- PR #2996: Removing the max_depth restriction for switching to the batched backend
- PR #3004: Remove Single Process Multi GPU (SPMG) code
- PR #3044: Move leftover `linalg` and `stats` to RAFT namespaces
- PR #3067: Deleting prims moved to RAFT and updating header paths
- PR #3074: Reducing dask coordinate descent test runtime

## Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/common/ml_benchmark.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
#pragma once

#include <benchmark/benchmark.h>
#include <common/cudart_utils.h>
#include <cuda_runtime.h>
#include <raft/cudart_utils.h>
#include <cuml/common/cuml_allocator.hpp>
#include <cuml/common/logger.hpp>
#include <cuml/common/utils.hpp>
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/add.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <linalg/add.cuh>
#include <raft/linalg/add.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/distance_common.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <distance/distance.cuh>
#include "../common/ml_benchmark.hpp"

Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/prims/fused_l2_nn.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <distance/fused_l2_nn.cuh>
#include <limits>
#include <linalg/norm.cuh>
#include <random/rng.cuh>
#include <raft/linalg/norm.cuh>
#include <raft/random/rng.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/gram_matrix.cu
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include <matrix/grammatrix.cuh>
#include <matrix/kernelfactory.cuh>
#include <memory>
#include <random/rng.cuh>
#include <raft/random/rng.cuh>
#include <sstream>
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/map_then_reduce.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <linalg/map_then_reduce.cuh>
#include <raft/linalg/map_then_reduce.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/matrix_vector_op.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <linalg/matrix_vector_op.cuh>
#include <raft/linalg/matrix_vector_op.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
4 changes: 2 additions & 2 deletions cpp/bench/prims/permute.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <raft/random/rng.cuh>
#include <random/permute.cuh>
#include <random/rng.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/reduce.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <linalg/reduce.cuh>
#include <raft/linalg/reduce.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
4 changes: 2 additions & 2 deletions cpp/bench/prims/rng.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <random/rng.cuh>
#include <raft/cudart_utils.h>
#include <raft/random/rng.cuh>
#include "../common/ml_benchmark.hpp"

namespace MLCommon {
Expand Down
4 changes: 2 additions & 2 deletions cpp/bench/sg/arima_loglikelihood.cu
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@

#include <cuml/tsa/arima_common.h>
#include <cuml/tsa/batched_arima.hpp>
#include <random/rng.cuh>
#include <raft/random/rng.cuh>

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include "benchmark.cuh"

namespace ML {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/sg/benchmark.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
#pragma once

#include <benchmark/benchmark.h>
#include <common/cudart_utils.h>
#include <cuda_runtime.h>
#include <raft/cudart_utils.h>
#include <cuml/common/logger.hpp>
#include <cuml/cuml.hpp>
#include "../common/ml_benchmark.hpp"
Expand Down
8 changes: 4 additions & 4 deletions cpp/bench/sg/dataset.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@

#pragma once

#include <common/cudart_utils.h>
#include <linalg/transpose.h>
#include <raft/cudart_utils.h>
#include <raft/linalg/transpose.h>
#include <common/cumlHandle.hpp>
#include <cuda_utils.cuh>
#include <cuml/cuml.hpp>
#include <cuml/datasets/make_blobs.hpp>
#include <fstream>
#include <iostream>
#include <linalg/unary_op.cuh>
#include <raft/cuda_utils.cuh>
#include <raft/linalg/unary_op.cuh>
#include <random/make_regression.cuh>
#include <sstream>
#include <string>
Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/sg/dataset_ts.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
#pragma once

#include <common/cumlHandle.hpp>
#include <cuda_utils.cuh>
#include <cuml/cuml.hpp>
#include <raft/cuda_utils.cuh>

#include <common/cudart_utils.h>
#include <random/rng.cuh>
#include <raft/cudart_utils.h>
#include <raft/random/rng.cuh>

namespace ML {
namespace Bench {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/sg/umap.cu
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

#include <cuda_utils.cuh>
#include <cuml/cuml.hpp>
#include <cuml/manifold/umap.hpp>
#include <raft/cuda_utils.cuh>
#include <utility>
#include "benchmark.cuh"

Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake/Dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ else(DEFINED ENV{RAFT_PATH})

ExternalProject_Add(raft
GIT_REPOSITORY https://github.com/rapidsai/raft.git
GIT_TAG 3f8a4bf6f81289f1fdaae9a5bd4a10de8674aa5c
GIT_TAG 9b3afe67895fbea397fb2c72375157aadfc132d8
PREFIX ${RAFT_DIR}
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/tsa/arima_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#include <algorithm>

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <thrust/execution_policy.h>
#include <thrust/for_each.h>
#include <thrust/iterator/counting_iterator.h>
Expand Down
6 changes: 3 additions & 3 deletions cpp/src/arima/batched_arima.cu
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@
#include <cuml/tsa/batched_arima.hpp>
#include <cuml/tsa/batched_kalman.hpp>

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <common/cumlHandle.hpp>
#include <common/device_buffer.hpp>
#include <common/nvtx.hpp>
#include <cuda_utils.cuh>
#include <linalg/batched/matrix.cuh>
#include <linalg/matrix_vector_op.cuh>
#include <metrics/batched/information_criterion.cuh>
#include <raft/cuda_utils.cuh>
#include <raft/linalg/matrix_vector_op.cuh>
#include <timeSeries/arima_helpers.cuh>

namespace ML {
Expand Down
6 changes: 3 additions & 3 deletions cpp/src/arima/batched_kalman.cu
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
#include <cuml/cuml.hpp>
#include <cuml/tsa/batched_kalman.hpp>

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <raft/linalg/cublas_wrappers.h>
#include <common/cumlHandle.hpp>
#include <common/device_buffer.hpp>
#include <common/nvtx.hpp>
#include <cuda_utils.cuh>
#include <linalg/batched/matrix.cuh>
#include <linalg/binary_op.cuh>
#include <raft/cuda_utils.cuh>
#include <raft/linalg/binary_op.cuh>
#include <sparse/batched/csr.cuh>
#include <timeSeries/arima_helpers.cuh>

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/common/allocatorAdapter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#include <cuml/cuml.hpp>

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <cuml/common/cuml_allocator.hpp>

namespace ML {
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/common/cumlHandle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include "cumlHandle.hpp"
#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <raft/linalg/cublas_wrappers.h>
#include <raft/linalg/cusolver_wrappers.h>
#include <raft/sparse/cusparse_wrappers.h>
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/common/cuml_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <cuml/cuml_api.h>
#include <raft/cudart_utils.h>
#include <cuml/common/utils.hpp>
#include <functional>
#include <raft/mr/device/allocator.hpp>
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/common/tensor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <cuml/common/cuml_allocator.hpp>
#include <vector>

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/dbscan/adjgraph/algo.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <thrust/scan.h>
#include <common/allocatorAdapter.hpp>
#include <common/cumlHandle.hpp>
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#include "../common.cuh"
#include "pack.h"

Expand Down
4 changes: 2 additions & 2 deletions cpp/src/dbscan/adjgraph/naive.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

#pragma once

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <common/cumlHandle.hpp>
#include <common/host_buffer.hpp>
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#include "../common.cuh"
#include "pack.h"

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/dbscan/dbscan.cu
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <common/cudart_utils.h>
#include <cuml/cuml_api.h>
#include <raft/cudart_utils.h>
#include <common/cumlHandle.hpp>
#include <cuml/cluster/dbscan.hpp>
#include "dbscan.cuh"
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/dbscan/runner.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@

#pragma once

#include <common/cudart_utils.h>
#include <raft/cudart_utils.h>
#include <common/cumlHandle.hpp>
#include <common/device_buffer.hpp>
#include <common/nvtx.hpp>
#include <cuda_utils.cuh>
#include <label/classlabels.cuh>
#include <raft/cuda_utils.cuh>
#include <sparse/csr.cuh>
#include "adjgraph/runner.cuh"
#include "vertexdeg/runner.cuh"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/dbscan/vertexdeg/naive.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#pragma once

#include <common/cumlHandle.hpp>
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#include "pack.h"

namespace Dbscan {
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/decisiontree/batched-levelalgo/builder_base.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
#include <common/device_buffer.hpp>
#include <common/grid_sync.cuh>
#include <common/host_buffer.hpp>
#include <cuda_utils.cuh>
#include <cuml/tree/decisiontree.hpp>
#include <raft/cuda_utils.cuh>
#include "input.cuh"
#include "kernels.cuh"
#include "node.cuh"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/decisiontree/batched-levelalgo/kernels.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#pragma once

#include <common/grid_sync.cuh>
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#include "input.cuh"
#include "metrics.cuh"
#include "node.cuh"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/decisiontree/batched-levelalgo/metrics.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#pragma once

#include <common/grid_sync.cuh>
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#include "input.cuh"
#include "node.cuh"
#include "split.cuh"
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/decisiontree/batched-levelalgo/split.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

#pragma once

#include <cuda_utils.cuh>
#include <linalg/unary_op.cuh>
#include <raft/cuda_utils.cuh>
#include <raft/linalg/unary_op.cuh>

namespace ML {
namespace DecisionTree {
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/decisiontree/decisiontree_impl.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#include <common/cudart_utils.h>
#include <decisiontree/quantile/quantile.h>
#include <raft/cudart_utils.h>
#include <common/iota.cuh>
#include <cuml/common/logger.hpp>
#include <iomanip>
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/decisiontree/levelalgo/common_helper.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

#pragma once

#include <common/cudart_utils.h>
#include <cuml/tree/flatnode.h>
#include <raft/cudart_utils.h>
#include <cuml/common/logger.hpp>
#include <random/rng.cuh>
#include <raft/random/rng.cuh>
#include <stats/minmax.cuh>
#include "common_kernel.cuh"

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/decisiontree/levelalgo/common_kernel.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
#pragma once
#include <cuda_utils.cuh>
#include <raft/cuda_utils.cuh>
#define LEAF 0xFFFFFFFF
#define PUSHRIGHT 0x00000001
#include <stats/minmax.cuh>
Expand Down
Loading

0 comments on commit 7e6d413

Please sign in to comment.