Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] deleting prims and updating paths #3067

Merged
merged 12 commits into from
Oct 31, 2020

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Oct 27, 2020

This PR deletes prims that were moved to RAFT recently to break circular dependency between libcuml and libcumlprims. Changes include deletions, updated header paths, and updated function calls

NOTE: updated function calls are for only those functions that are calling into libcumlprims. Other files purely just update their header paths

@divyegala divyegala requested review from a team as code owners October 27, 2020 20:09
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@divyegala
Copy link
Member Author

Dependencies:

  1. [REVIEW] missing headers for newly moved prims raft#86
  2. PR in libcumlprims to fix a couple of small things

Copy link
Member

@teju85 teju85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is the raft dependency update that needs to be done in cmake file prior to merging this PR. Apart from that overall LGTM. Pre-approving.

cpp/cmake/Dependencies.cmake Outdated Show resolved Hide resolved
@dantegd
Copy link
Member

dantegd commented Oct 29, 2020

@divyegala PR rapidsai/raft#86 has been merged, could you update the pinned raft version in this PR so we can merge it? Thanks!

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a request changes review so we change the pinned raft to mainline raft before merging now that rapidsai/raft#86 has been merged

@dantegd dantegd added the 4 - Waiting on Author Waiting for author to respond to review label Oct 29, 2020
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #3067 into branch-0.17 will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3067      +/-   ##
===============================================
+ Coverage        58.39%   59.20%   +0.81%     
===============================================
  Files              143      142       -1     
  Lines             8897     8966      +69     
===============================================
+ Hits              5195     5308     +113     
+ Misses            3702     3658      -44     
Impacted Files Coverage Δ
python/cuml/datasets/blobs.py 73.84% <0.00%> (-4.62%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.50% <0.00%> (-4.05%) ⬇️
python/cuml/common/import_utils.py 61.95% <0.00%> (-2.42%) ⬇️
python/cuml/pytest_benchmarks/test_bench.py 100.00% <0.00%> (ø)
python/cuml/dask/common/spmg_ipc.py
python/cuml/common/array.py 97.72% <0.00%> (+0.01%) ⬆️
python/cuml/metrics/_ranking.py 98.61% <0.00%> (+0.03%) ⬆️
python/cuml/preprocessing/encoders.py 95.18% <0.00%> (+0.07%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.45% <0.00%> (+0.12%) ⬆️
python/cuml/naive_bayes/naive_bayes.py 92.69% <0.00%> (+0.16%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30644b4...c847772. Read the comment docs.

@divyegala divyegala added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Author Waiting for author to respond to review labels Oct 30, 2020
@dantegd dantegd merged commit 7e6d413 into rapidsai:branch-0.17 Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants