-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] deleting prims and updating paths #3067
[REVIEW] deleting prims and updating paths #3067
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Dependencies:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing is the raft dependency update that needs to be done in cmake file prior to merging this PR. Apart from that overall LGTM. Pre-approving.
@divyegala PR rapidsai/raft#86 has been merged, could you update the pinned raft version in this PR so we can merge it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a request changes review so we change the pinned raft to mainline raft before merging now that rapidsai/raft#86 has been merged
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3067 +/- ##
===============================================
+ Coverage 58.39% 59.20% +0.81%
===============================================
Files 143 142 -1
Lines 8897 8966 +69
===============================================
+ Hits 5195 5308 +113
+ Misses 3702 3658 -44
Continue to review full report at Codecov.
|
This PR deletes prims that were moved to RAFT recently to break circular dependency between libcuml and libcumlprims. Changes include deletions, updated header paths, and updated function calls
NOTE: updated function calls are for only those functions that are calling into libcumlprims. Other files purely just update their header paths