[REVIEW] Avoid useless copy when exchanging flag buffers in CSR WeakCC #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3096 +/- ##
============================================
Coverage 69.38% 69.38%
============================================
Files 193 193
Lines 14704 14704
============================================
Hits 10203 10203
Misses 4501 4501 Continue to review full report at Codecov.
|
teju85
requested changes
Oct 31, 2020
dantegd
added
4 - Waiting on Reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was going through the DBSCAN code, I noticed that in the CSR Weak Connected Components implementation, the flag buffers are exchanged with memory copies (and, worse, with 2 device->host and 2 host->device copies).
This can be done by simply switching the pointers. It is faster, uses less memory, and more elegant.