Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Treelite 1.3.0 #3855

Merged
merged 7 commits into from
May 14, 2021
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented May 13, 2021

Upgrade to Treelite 1.3.0 to take advantage of the following new features:

Make progress towards #3853

Depends on rapidsai/integration#270

@hcho3 hcho3 requested review from a team as code owners May 13, 2021 01:05
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels May 13, 2021
@hcho3 hcho3 requested a review from a team as a code owner May 13, 2021 01:07
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 13, 2021
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 5 - Merge After Dependencies Depends on another PR: do not merge out of order labels May 13, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented May 13, 2021

Will need to update Treelite in integration.

@hcho3
Copy link
Contributor Author

hcho3 commented May 13, 2021

Blocked by rapidsai/integration#270

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving; just need to remove one bit of testing code.

ci/gpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI gpuCI issue label May 13, 2021
Comment on lines +1061 to +1063
clf.convert_to_treelite_model().to_treelite_checkpoint(checkpoint_path)

tl_model = treelite.Model.deserialize(checkpoint_path)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add a convenience method to directly convert an RF object into a Treelite Model object.

@hcho3
Copy link
Contributor Author

hcho3 commented May 13, 2021

The memory error in gpuCI (*** Error in './test/ml': free(): invalid pointer: 0x00007f632b691fe8 ***) is addressed in rapidsai/raft#229 and #3860

@hcho3
Copy link
Contributor Author

hcho3 commented May 14, 2021

Rerun tests

@codecov-commenter
Copy link

Codecov Report

Merging #3855 (9ab3c2a) into branch-0.20 (46174b7) will decrease coverage by 0.55%.
The diff coverage is 55.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #3855      +/-   ##
===============================================
- Coverage        85.96%   85.41%   -0.56%     
===============================================
  Files              225      227       +2     
  Lines            16986    17317     +331     
===============================================
+ Hits             14602    14791     +189     
- Misses            2384     2526     +142     
Flag Coverage Δ
dask 48.93% <24.09%> (-0.03%) ⬇️
non-dask 77.35% <52.71%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/benchmark/nvtx_benchmark.py 0.00% <0.00%> (ø)
python/cuml/common/memory_utils.py 79.26% <ø> (+0.51%) ⬆️
python/cuml/dask/common/utils.py 43.68% <0.00%> (ø)
python/cuml/ensemble/randomforestclassifier.pyx 83.61% <ø> (ø)
python/cuml/linear_model/logistic_regression.pyx 89.21% <ø> (ø)
python/cuml/neighbors/nearest_neighbors.pyx 93.11% <ø> (-0.03%) ⬇️
python/cuml/tsa/auto_arima.pyx 57.48% <0.00%> (-0.53%) ⬇️
python/cuml/common/base.pyx 74.10% <29.41%> (-6.23%) ⬇️
python/cuml/model_selection/_split.py 88.99% <75.67%> (-1.87%) ⬇️
python/cuml/manifold/t_sne.pyx 78.34% <76.31%> (-1.00%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917e7ca...9ab3c2a. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented May 14, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4d06991 into rapidsai:branch-0.20 May 14, 2021
@hcho3 hcho3 deleted the upgrade_treelite branch May 14, 2021 15:32
rapids-bot bot pushed a commit that referenced this pull request Jun 30, 2021
This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to #3855.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #4014
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Upgrade to Treelite 1.3.0 to take advantage of the following new features:

* Faster model import for scikit-learn tree models (dmlc/treelite#264). Fixes rapidsai#3768
* Binary serializer to a file stream (dmlc/treelite#270, dmlc/treelite#273)
* [EXPERIMENTAL] Add GTIL, reference inference backend (dmlc/treelite#274)

Make progress towards rapidsai#3853

Depends on rapidsai/integration#270

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3855
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to rapidsai#3855.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#4014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Merge After Dependencies Depends on another PR: do not merge out of order CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Speed up sklearn imports to FIL / treelite
5 participants