Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update treelite version in get_treelite.cmake #4014

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Update treelite version in get_treelite.cmake #4014

merged 2 commits into from
Jun 30, 2021

Conversation

ajschmidt8
Copy link
Member

This PR updates get_treelite.cmake to use treelite version 1.3.0, similarly to #3855.

This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to #3855.
@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Jun 25, 2021
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner June 25, 2021 16:47
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the bad function name.

Looks correct to me as the conda recipes are already pulling down 1.3.0

@ajschmidt8
Copy link
Member Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Jun 29, 2021

rerun tests

@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 29, 2021
@dantegd
Copy link
Member

dantegd commented Jun 29, 2021

@gpucibot merge

@ajschmidt8
Copy link
Member Author

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented Jun 30, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@76e6b51). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4014   +/-   ##
===============================================
  Coverage                ?   85.49%           
===============================================
  Files                   ?      230           
  Lines                   ?    18452           
  Branches                ?        0           
===============================================
  Hits                    ?    15776           
  Misses                  ?     2676           
  Partials                ?        0           
Flag Coverage Δ
dask 48.45% <0.00%> (?)
non-dask 77.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e6b51...032899c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 2f1b9ff into rapidsai:branch-21.08 Jun 30, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to rapidsai#3855.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#4014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants