-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update treelite
version in get_treelite.cmake
#4014
Conversation
This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to #3855.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on the bad function name.
Looks correct to me as the conda recipes are already pulling down 1.3.0
rerun tests |
rerun tests |
@gpucibot merge |
rerun tests |
1 similar comment
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4014 +/- ##
===============================================
Coverage ? 85.49%
===============================================
Files ? 230
Lines ? 18452
Branches ? 0
===============================================
Hits ? 15776
Misses ? 2676
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This PR updates `get_treelite.cmake` to use `treelite` version `1.3.0`, similarly to rapidsai#3855. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#4014
This PR updates
get_treelite.cmake
to usetreelite
version1.3.0
, similarly to #3855.