Remove Raft deprecated headers #4858
Conversation
|
rerun tests |
lowener
added
3 - Ready for Review
|
rerun tests |
|
rerun tests |
There was a problem hiding this comment.
@lowener your changes look great so far. I ended up going through these files in bulk, grepping the include lines of the files to verify the proper use of hpp and cuh everywhere. I did find a couple files that are still using the incorrect includes (from a recent PR). I'm posing them here since the files aren't actually included in your PR:
These should be using cuh:
cjnolet@gpudev /share/workspace/rapids_projects/cuml ((HEAD detached at lowener/22.10-raft-deprecated)) $ grep -R "#include <raft.*linalg.*hpp" cpp/src
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/linalg/matrix_vector_op.hpp>
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/linalg/norm.hpp>
cjnolet@gpudev /share/workspace/rapids_projects/cuml ((HEAD detached at lowener/22.10-raft-deprecated)) $ grep -R "#include <raft.*csr.*hpp" cpp/src
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/sparse/convert/csr.hpp>
cjnolet@gpudev /share/workspace/rapids_projects/cuml ((HEAD detached at lowener/22.10-raft-deprecated)) $ grep -R "#include <raft.*label.*hpp" cpp/src
cpp/src/hdbscan/condensed_hierarchy.cu:#include <raft/label/classlabels.hpp>
cpp/src/hdbscan/detail/membership.cuh:#include <raft/label/classlabels.hpp>
cpp/src/hdbscan/detail/select.cuh:#include <raft/label/classlabels.hpp>
cpp/src/hdbscan/detail/extract.cuh:#include <raft/label/classlabels.hpp>
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/label/classlabels.hpp>
cpp/src/hdbscan/detail/stabilities.cuh:#include <raft/label/classlabels.hpp>
cpp/src/svm/svc_impl.cuh:#include <raft/label/classlabels.hpp>
cjnolet@gpudev /share/workspace/rapids_projects/cuml ((HEAD detached at lowener/22.10-raft-deprecated)) $ grep -R "#include <raft.*matrix.*hpp" cpp/src
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/linalg/matrix_vector_op.hpp>
cpp/src/hdbscan/detail/soft_clustering.cuh:#include <raft/matrix/math.hpp>
All of the includes from core/ look correct.
Codecov ReportBase: 78.02% // Head: 78.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #4858 +/- ##
================================================
+ Coverage 78.02% 78.07% +0.05%
================================================
Files 180 180
Lines 11385 11443 +58
================================================
+ Hits 8883 8934 +51
- Misses 2502 2509 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
I looked through all the files and didn't see anything further. I also grepped through the files again and didn't see any other missed files. I did notice one very tiny typo, which wasn't the fault of these changes but we could probably fix it while we're already making changes to the offending file. I'm still approving, though, since it's so minor.
|
@gpucibot merge |
|
rerun tests |
This should be merged before the Raft PR: rapidsai/raft#753. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - William Hicks (https://github.com/wphicks) URL: rapidsai#4858
This should be merged before the Raft PR: rapidsai/raft#753.