Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Raft deprecated headers #4858

Merged
merged 20 commits into from
Sep 8, 2022
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/bench/common/ml_benchmark.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include <cuml/common/logger.hpp>
#include <cuml/common/utils.hpp>
#include <memory>
#include <raft/cudart_utils.h>
#include <raft/core/cudart_utils.hpp>
#include <sstream>
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/add.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/linalg/add.hpp>
#include <raft/linalg/add.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/prims/distance_common.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/cudart_utils.h>
#include <raft/distance/distance.hpp>
#include <raft/distance/specializations.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/distance/distance.cuh>
#include <raft/distance/specializations.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
12 changes: 6 additions & 6 deletions cpp/bench/prims/fused_l2_nn.cu
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@

#include <common/ml_benchmark.hpp>
#include <limits>
#include <raft/cudart_utils.h>
#include <raft/distance/fused_l2_nn.hpp>
#include <raft/handle.hpp>
#include <raft/linalg/norm.hpp>
#include <raft/random/rng.hpp>
#include <raft/spatial/knn/specializations.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/distance/fused_l2_nn.cuh>
#include <raft/core/handle.hpp>
#include <raft/linalg/norm.cuh>
#include <raft/random/rng.cuh>
#include <raft/spatial/knn/specializations.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/gram_matrix.cu
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include <memory>
// #TODO: Replace with public header when ready
#include <raft/linalg/detail/cublas_wrappers.hpp>
#include <raft/random/rng.hpp>
#include <raft/random/rng.cuh>
#include <sstream>
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/make_blobs.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/random/make_blobs.hpp>
#include <raft/random/make_blobs.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/map_then_reduce.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/linalg/map_then_reduce.hpp>
#include <raft/linalg/map_then_reduce.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/matrix_vector_op.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/linalg/matrix_vector_op.hpp>
#include <raft/linalg/matrix_vector_op.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/prims/permute.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/cudart_utils.h>
#include <raft/random/permute.hpp>
#include <raft/random/rng.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/random/permute.cuh>
#include <raft/random/rng.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
2 changes: 1 addition & 1 deletion cpp/bench/prims/reduce.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/linalg/reduce.hpp>
#include <raft/linalg/reduce.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
4 changes: 2 additions & 2 deletions cpp/bench/prims/rng.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/

#include <common/ml_benchmark.hpp>
#include <raft/cudart_utils.h>
#include <raft/random/rng.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/random/rng.cuh>

namespace MLCommon {
namespace Bench {
Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/sg/arima_loglikelihood.cu
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@

#include <cuml/tsa/arima_common.h>
#include <cuml/tsa/batched_arima.hpp>
#include <raft/handle.hpp>
#include <raft/random/rng.hpp>
#include <raft/core/handle.hpp>
#include <raft/random/rng.cuh>
#include <rmm/device_uvector.hpp>

#include "benchmark.cuh"
#include <raft/cudart_utils.h>
#include <raft/core/cudart_utils.hpp>

namespace ML {
namespace Bench {
Expand Down
4 changes: 2 additions & 2 deletions cpp/bench/sg/benchmark.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
#include <benchmark/benchmark.h>
#include <cuda_runtime.h>
#include <cuml/common/logger.hpp>
#include <raft/cudart_utils.h>
#include <raft/handle.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace Bench {
Expand Down
10 changes: 5 additions & 5 deletions cpp/bench/sg/dataset.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
#include <fstream>
#include <iostream>
#include <raft/cuda_utils.cuh>
#include <raft/cudart_utils.h>
#include <raft/handle.hpp>
#include <raft/linalg/transpose.hpp>
#include <raft/linalg/unary_op.hpp>
#include <raft/random/make_regression.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/core/handle.hpp>
#include <raft/linalg/transpose.cuh>
#include <raft/linalg/unary_op.cuh>
#include <raft/random/make_regression.cuh>
#include <sstream>
#include <string>
#include <vector>
Expand Down
6 changes: 3 additions & 3 deletions cpp/bench/sg/dataset_ts.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
#pragma once

#include <raft/cuda_utils.cuh>
#include <raft/cudart_utils.h>
#include <raft/handle.hpp>
#include <raft/random/rng.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/core/handle.hpp>
#include <raft/random/rng.cuh>

namespace ML {
namespace Bench {
Expand Down
15 changes: 8 additions & 7 deletions cpp/cmake/thirdparty/get_cumlprims_mg.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ function(find_and_configure_cumlprims_mg)
endif()

rapids_cpm_find(cumlprims_mg ${PKG_VERSION}
GLOBAL_TARGETS cumlprims_mg::cumlprims_mg
BUILD_EXPORT_SET cuml-exports
INSTALL_EXPORT_SET cuml-exports
GLOBAL_TARGETS cumlprims_mg::cumlprims_mg
BUILD_EXPORT_SET cuml-exports
INSTALL_EXPORT_SET cuml-exports
SOURCE_SUBDIR cpp
CPM_ARGS
GIT_REPOSITORY git@github.com:${PKG_FORK}/cumlprims_mg.git
GIT_TAG ${PKG_PINNED_TAG}
GIT_REPOSITORY git@github.com:${PKG_FORK}/cumlprims_mg.git
GIT_TAG ${PKG_PINNED_TAG}
)

endfunction()
Expand All @@ -49,8 +50,8 @@ endfunction()
# `-D CPM_cumlprims_mg_SOURCE=/path/to/cumlprims_mg`
###
find_and_configure_cumlprims_mg(VERSION ${CUML_MIN_VERSION_cumlprims_mg}
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_cumlprims_mg}
FORK lowener
PINNED_TAG 22.10-raft-headers
lowener marked this conversation as resolved.
Show resolved Hide resolved
# When PINNED_TAG above doesn't match cuml,
# force local cumlprims_mg clone in build directory
# even if it's already installed.
Expand Down
4 changes: 2 additions & 2 deletions cpp/cmake/thirdparty/get_raft.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ endfunction()
# To use a different RAFT locally, set the CMake variable
# CPM_raft_SOURCE=/path/to/local/raft
find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft}
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK lowener
PINNED_TAG 22.10-rm-deprecated
lowener marked this conversation as resolved.
Show resolved Hide resolved

# When PINNED_TAG above doesn't match cuml,
# force local raft clone in build directory
Expand Down
2 changes: 1 addition & 1 deletion cpp/examples/dbscan/dbscan_example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <sstream>
#include <vector>

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

#include <cuml/cluster/dbscan.hpp>

Expand Down
2 changes: 1 addition & 1 deletion cpp/examples/kmeans/kmeans_example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

#include <cuda_runtime.h>

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

#include <cuml/cluster/kmeans.hpp>

Expand Down
2 changes: 1 addition & 1 deletion cpp/examples/symreg/symreg_example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include <cuml/genetic/genetic.h>
#include <cuml/genetic/program.h>

#include <raft/cudart_utils.h>
#include <raft/core/cudart_utils.hpp>
#include <rmm/device_scalar.hpp>
#include <rmm/device_uvector.hpp>

Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/cluster/hdbscan.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include <raft/distance/distance_type.hpp>

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

#include <rmm/device_uvector.hpp>

Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/cluster/linkage.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <raft/distance/distance_type.hpp>
#include <raft/sparse/hierarchy/common.h>

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

namespace raft {
class handle_t;
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cuml/common/utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@

#include <cuda_runtime.h>
#include <execinfo.h>
#include <raft/cudart_utils.h>
#include <raft/core/cudart_utils.hpp>

#include <cstdio>

#include <raft/error.hpp>
#include <raft/core/error.hpp>
#include <sstream>
#include <stdexcept>
#include <string>
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/decomposition/sign_flip_mg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include <cumlprims/opg/matrix/data.hpp>
#include <cumlprims/opg/matrix/part_descriptor.hpp>
#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace PCA {
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/genetic/genetic.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

#include "common.h"
#include "program.h"
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/genetic/program.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>
#include <random>

#include "common.h"
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/linear_model/glm.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#include <cuml/linear_model/qn.h>

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace GLM {
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cuml/linear_model/preprocess_mg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

#include <cumlprims/opg/matrix/data.hpp>
#include <cumlprims/opg/matrix/part_descriptor.hpp>
#include <raft/comms/comms.hpp>
#include <raft/handle.hpp>
#include <raft/core/comms.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace GLM {
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/neighbors/knn_mg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>
#include <vector>

#include <cumlprims/opg/matrix/data.hpp>
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/random_projection/rproj_c.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>
#include <rmm/device_uvector.hpp>

namespace ML {
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/solvers/lars.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace Solver {
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/svm/linear.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#pragma once

#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

namespace ML {
namespace SVM {
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/svm/svc.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include "svm_parameter.h"
#include <cuml/common/logger.hpp>
#include <cuml/matrix/kernelparams.h>
#include <raft/handle.hpp>
#include <raft/core/handle.hpp>

// namespace raft {
// class handle_t;
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuml/tsa/arima_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#include <algorithm>

#include <raft/cudart_utils.h>
#include <raft/core/cudart_utils.hpp>
#include <thrust/execution_policy.h>
#include <thrust/for_each.h>
#include <thrust/iterator/counting_iterator.h>
Expand Down
8 changes: 4 additions & 4 deletions cpp/src/arima/batched_arima.cu
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
#include <common/nvtx.hpp>
#include <linalg/batched/matrix.cuh>
#include <metrics/batched/information_criterion.cuh>
#include <raft/common/nvtx.hpp>
#include <raft/core/nvtx.hpp>
#include <raft/cuda_utils.cuh>
#include <raft/cudart_utils.h>
#include <raft/handle.hpp>
#include <raft/linalg/matrix_vector_op.hpp>
#include <raft/core/cudart_utils.hpp>
#include <raft/core/handle.hpp>
#include <raft/linalg/matrix_vector_op.cuh>
#include <rmm/device_uvector.hpp>
#include <timeSeries/arima_helpers.cuh>
#include <timeSeries/fillna.cuh>
Expand Down
Loading