Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target branch-24.04 for GitHub Actions workflows #5776

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 15, 2024

Description

Follow-up to #5711

For all GitHub Actions configs, replaces uses of the test-cuda-12.2 branch on shared-workflows
with branch-24.04, now that rapidsai/shared-workflows#166 has been merged.

Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

(created with rapids-reviser)

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 15, 2024
@jameslamb jameslamb marked this pull request as ready for review February 15, 2024 20:18
@jameslamb jameslamb requested a review from a team as a code owner February 15, 2024 20:18
@jakirkham
Copy link
Member

jakirkham commented Feb 15, 2024

Restarting CI

Edit: Restarting again

@jakirkham
Copy link
Member

After offline discussion, we believe the CI errors seen here were fixed with PR: rapidsai/raft#2118

@jakirkham jakirkham closed this Feb 16, 2024
@jakirkham jakirkham reopened this Feb 16, 2024
@jakirkham
Copy link
Member

Some CI jobs had network issues. Restarting those jobs

@jakirkham
Copy link
Member

Had a couple failures. Restarted CI

@jakirkham
Copy link
Member

Retesting with RAFT packages built using PR: rapidsai/raft#2185

@jakirkham jakirkham closed this Feb 21, 2024
@jakirkham jakirkham reopened this Feb 21, 2024
@jakirkham
Copy link
Member

Mostly passing! 🎉

Wheel jobs failed due to network issues (git clone failed). Network issues are being investigated separately

Also saw test_dask_logistic_regression.py fail in a couple spots. However this is a known flaky test ( #5711 (comment) )

Restarting failed CI jobs

@jakirkham
Copy link
Member

This is now passing! 🎉

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f16a8a9 into rapidsai:branch-24.04 Feb 21, 2024
143 of 154 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@jameslamb jameslamb deleted the gha-cuda-12.2 branch February 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants