Update raft for compatibility with the latest cuco #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
PointKernel
changed the title
PointKernel
force-pushed
the
fix-cuco-conflicts
branch
from
4e82910
to
204a542
Compare
vyasr
added
improvement
cjnolet
reviewed
Feb 9, 2024
| using smem_type = typename insert_type::slot_type*; | ||
| using find_type = | ||
| typename cuco::static_map<value_idx, value_t, cuda::thread_scope_block>::device_view; | ||
| typename cuco::legacy::static_map<value_idx, value_t, cuda::thread_scope_block>::device_view; |
There was a problem hiding this comment.
Legacy- should we be concerned that this feature is no longer supported? Or is there another similar API we can migrate this to.
There was a problem hiding this comment.
is there another similar API we can migrate this to
Yes, we added a more performant new map and it's ready to use. I can put up a PR afterward for the map migration.
PointKernel
changed the title
bdice
approved these changes
Feb 15, 2024
cjnolet
approved these changes
Feb 15, 2024
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Feb 15, 2024
This PR bumps to the latest cuco version which removes experimental namespace and includes multiple bug fixes. CI must pass on these PRs before we can merge this change: - [ ] rapidsai/cudf#14849 - [ ] rapidsai/cugraph#4111 - [ ] rapidsai/raft#2118 Authors: - Yunsong Wang (https://github.com/PointKernel) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #526
PointKernel
changed the title
|
This is ready to go once CI passes. Note the CI will be blocked until this PR gets merged. Thanks! |
|
Can someone please rerun the failed CI task? I didn't see a similar issue in previous CI checks thus maybe it's a random CI error? |
|
@cjnolet If this is ready, would you please merge this? This PR is the next step for rapidsai/rapids-cmake#526 |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates raft to make it compatible with the latest cuco.
Depends on rapidsai/rapids-cmake#526
CMake changes will be reverted once rapidsai/rapids-cmake#526 is merged.