Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use a static gtest and gbench #5847

Merged

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Apr 15, 2024

Removes the need for us to install GTest or GBench in our cuml testing CI

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change labels Apr 15, 2024
@robertmaynard robertmaynard requested review from a team as code owners April 15, 2024 13:42
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 390fc2f into rapidsai:branch-24.06 Apr 15, 2024
59 checks passed
@robertmaynard robertmaynard deleted the fea/static_test_dependencies branch April 15, 2024 20:04
rapids-bot bot pushed a commit that referenced this pull request Apr 22, 2024
Not needed anymore with the merging of #5847

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #5854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants