Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically link gtest/gbench/nvbench into all C++ test/benchmark executables #32

Closed
vyasr opened this issue Mar 26, 2024 · 2 comments
Closed

Statically link gtest/gbench/nvbench into all C++ test/benchmark executables #32

vyasr opened this issue Mar 26, 2024 · 2 comments
Assignees
@robertmaynard

Comments

@vyasr
Copy link
Contributor

vyasr commented Mar 26, 2024

Currently we typically dynamically link gtest/gbench/nvbench into our tests/benchmarks. This is unnecessary and it makes these executables harder to consume for people who want to run our tests/benchmarks. We should change this default across RAPIDS. The first step will be updating rapids-cmake to support using gtest statically. Once that is done, we can start rolling out the changes across RAPIDS.
@robertmaynard robertmaynard mentioned this issue Apr 9, 2024
Merged
7 tasks
@robertmaynard
Copy link

robertmaynard commented Apr 15, 2024 •
edited
Loading

PRs to resolve this issue in RAPIDS repos:

@vyasr vyasr mentioned this issue Apr 16, 2024
Merged
3 tasks
@robertmaynard robertmaynard mentioned this issue Apr 23, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Apr 23, 2024
@robertmaynard
Remove gtest dependency from ucxx test conda package (#223)
bdd3ff9 
Part of the effort to move all of RAPIDS over to a set of static testing / benchmarking libraries ( rapidsai/build-planning#32 ).

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #223
@robertmaynard robertmaynard self-assigned this Apr 30, 2024
@robertmaynard
Copy link

Closing as RAPIDS has been converted to static gtest/gbench/nvbench

@vyasr vyasr mentioned this issue May 9, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue May 10, 2024
@vyasr
Always use a static gtest (#167)
4187cfa 
Contributes to rapidsai/build-planning#32

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - https://github.com/damontecres
  - Ray Douglass (https://github.com/raydouglass)

URL: #167
@vyasr vyasr mentioned this issue Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertmaynard robertmaynard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertmaynard @vyasr