Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update telemetry actions to fluent-bit friendly style #6186

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

msarahan
Copy link
Contributor

Simplifies telemetry a bit. More details at rapidsai/shared-actions#28.

Telemetry will still not be collected until @ajschmidt8 enables the TELEMETRY_ENABLED environment variable for this repo.

Copy link

copy-pr-bot bot commented Dec 17, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@msarahan msarahan added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2024
@msarahan msarahan marked this pull request as ready for review December 17, 2024 22:06
@msarahan msarahan requested a review from a team as a code owner December 17, 2024 22:06
@msarahan
Copy link
Contributor Author

re-running CI now that TELEMETRY_ENABLED=true (this is an org-level env var that @ajschmidt8 enabled here)

@msarahan msarahan closed this Dec 17, 2024
@msarahan msarahan reopened this Dec 17, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing runs-on: linux-amd64-cpu4?

@msarahan
Copy link
Contributor Author

yes, thanks for catching that.

@msarahan msarahan force-pushed the update-telemetry-actions branch from 80c4778 to 3a96150 Compare December 18, 2024 00:28
@msarahan
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9f9f66a into rapidsai:branch-25.02 Dec 18, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants