Simplify and document dispatch action strategy #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
|
/ok to test |
msarahan
commented
Dec 10, 2024
msarahan
force-pushed
the
empty-certs
branch
from
04a9712 to
823b173
Compare
|
The change from otel-cli to the opentelemety python SDK isn't going as well as I thought/hoped. I'm going to split that off from this PR. |
msarahan
force-pushed
the
empty-certs
branch
6 times, most recently
from
8ff7993 to
2dd0d20
Compare
ajschmidt8
reviewed
Dec 16, 2024
ajschmidt8
reviewed
Dec 17, 2024
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
msarahan
force-pushed
the
empty-certs
branch
from
5493294 to
0f577cd
Compare
ajschmidt8
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Dec 17, 2024
The goal here is to remove the need for certificates. Any worker that is not in our VPC can talk directly to fluentbit, and fluentbit will be configured with certificates to talk to Tempo. The implementation implication is that we need to run telemetry stuff ONLY on nodes in our VPC. To avoid needing to move all jobs to these nodes, we instead temporarily store telemetry data as artifacts, and in one final job, we process and send telemetry info for all jobs from one job. Part of rapidsai/shared-workflows#269 and rapidsai/shared-actions#28 Authors: - Mike Sarahan (https://github.com/msarahan) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1750
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 18, 2024
Simplifies telemetry a bit. More details at rapidsai/shared-actions#28. Telemetry will still not be collected until @ajschmidt8 enables the TELEMETRY_ENABLED environment variable for this repo. Authors: - Mike Sarahan (https://github.com/msarahan) Approvers: - Bradley Dice (https://github.com/bdice) URL: #17615
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Dec 18, 2024
Simplifies telemetry a bit. More details at rapidsai/shared-actions#28. Telemetry will still not be collected until @ajschmidt8 enables the `TELEMETRY_ENABLED` environment variable for this repo. Authors: - Mike Sarahan (https://github.com/msarahan) Approvers: - Bradley Dice (https://github.com/bdice) URL: #4834
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Dec 18, 2024
Simplifies telemetry a bit. More details at rapidsai/shared-actions#28. Telemetry will still not be collected until @ajschmidt8 enables the TELEMETRY_ENABLED environment variable for this repo. Authors: - Mike Sarahan (https://github.com/msarahan) Approvers: - Bradley Dice (https://github.com/bdice) URL: #6186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs for the "dispatch action" pattern that we use for the telemetry actions. It also refactors the actions for simplicity, including changing out the go-based otel-cli for direct use of the official opentelemetry Python SDK.