remove certs and simplify telemetry summarize #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
msarahan
added
2 - In Progress
|
/ok to test |
|
/ok to test |
3 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
msarahan
force-pushed
the
telemetry-without-certs
branch
from
9c55600 to
e07b378
Compare
|
/ok to test |
|
AJ has just re-enabled the TELEMETRY_ENABLED configuration variable. The next run here should show telemetry being captured. |
|
/ok to test |
|
/ok to test |
1 similar comment
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
msarahan
force-pushed
the
telemetry-without-certs
branch
from
e78a58a to
b4db92d
Compare
|
/ok to test |
msarahan
added
3 - Ready for review
|
/ok to test |
msarahan
force-pushed
the
telemetry-without-certs
branch
from
e26de8d to
a939f09
Compare
msarahan
force-pushed
the
telemetry-without-certs
branch
from
a939f09 to
1e57c73
Compare
bdice
reviewed
Dec 17, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Dec 17, 2024
bdice
removed
the
tech debt
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal here is to remove the need for certificates. Any worker that is not in our VPC can talk directly to fluentbit, and fluentbit will be configured with certificates to talk to Tempo. The implementation implication is that we need to run telemetry stuff ONLY on nodes in our VPC. To avoid needing to move all jobs to these nodes, we instead temporarily store telemetry data as artifacts, and in one final job, we process and send telemetry info for all jobs from one job.
Part of rapidsai/shared-workflows#269 and rapidsai/shared-actions#28
Checklist