Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward merge 0.19 into 0.20 #374

Merged
merged 5 commits into from
Apr 8, 2021

Conversation

raydouglass
Copy link
Member

DO NOT USE auto-merger, this must be merged with a merge commit!

This follows up on #371

trxcllnt and others added 4 commits March 25, 2021 21:13
…i#365)

This PR includes many of the same changes as were made in [cudf/pull/7107](rapidsai/cudf#7107).

* Export `cuspatial::cuspatial` CMake alias targets.
* Fixes -Wall errors discovered when changing compile flags.
* Use `CPMFindPackage` to find `libcudf` installed on the system or build `libcudf` from source.

edit: Depends on rapidsai/cudf#7574 and rapidsai/cudf#7734

Authors:
  - Paul Taylor (@trxcllnt)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - Mark Harris (@harrism)
  - Keith Kraus (@kkraus14)

URL: rapidsai#365
Ensure all conda packages created in this repo that depend on other packages are all version pinned to the same build number. This way it prevents a conda solve from picking mismatched versions of `cuspatial` and `libcuspatial` that can break this repo during builds and testing.

Authors:
  - Mike Wendt (@mike-wendt)

Approvers:
  - Ray Douglass (@raydouglass)

URL: rapidsai#370
@raydouglass raydouglass added the 3 - Ready for Review Ready for review by team label Apr 7, 2021
@raydouglass raydouglass self-assigned this Apr 7, 2021
@raydouglass raydouglass requested review from a team as code owners April 7, 2021 14:43
@github-actions github-actions bot added cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Apr 7, 2021
@raydouglass raydouglass added non-breaking Non-breaking change tech debt Related to improving software quality improvement Improvement / enhancement to an existing function labels Apr 7, 2021
@raydouglass raydouglass changed the title Forward merge 0.19 into 0.20 [skip-ci] Forward merge 0.19 into 0.20 Apr 7, 2021
@raydouglass
Copy link
Member Author

rerun tests

@kkraus14
Copy link
Contributor

kkraus14 commented Apr 7, 2021

10:59:21 fatal: invalid reference: branch-.
10:59:21 CMake Error at cudf-subbuild/cudf-populate-prefix/tmp/cudf-populate-gitclone.cmake:40 (message):
10:59:21   Failed to checkout tag: 'branch-.'

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@raydouglass raydouglass force-pushed the branch-0.20-merge-0.19 branch from d1fadd6 to 78e3db6 Compare April 7, 2021 17:26
@ajschmidt8 ajschmidt8 merged commit c44f92d into rapidsai:branch-0.20 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code tech debt Related to improving software quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants