Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ pairwise linestring distance #510
C++ pairwise linestring distance #510
Changes from all commits
0f2c62c
29f1d62
954bbfc
03748ea
3b52203
6deb261
61716c6
95a803f
3375b1b
3cab72d
1c6322e
f6b571a
2c3a038
90de8ce
3efb6b0
a637664
d82f887
80e2d27
813178c
aa65c75
511dd5d
cee2c1f
3bf3d44
2006ac1
f463bd8
08ef028
53e822a
5dd6a4c
2b1da4a
d8e6902
2341301
cc6f1a2
daa2966
decac94
0f139e0
30ac95c
53a4135
b606956
6811cb6
90a5102
77b27a9
468a5e9
c5df642
777a01a
aa93829
e0a15d8
877d74e
2a58b0e
6fdd25a
9fa8136
39baadf
cc0f526
f55db25
22ed7ec
a477f2b
708906d
2dc421b
497f1d1
c09689a
7023faa
8004ec9
654c08b
c864dca
ddf497e
1203a86
2da3a66
338a5ad
94b78f3
a3e84ee
c40b81f
65a835c
23875ee
ac53f8d
b546e7a
26fa8d4
b7dda2c
2c60a5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For discussion: Could/should the
linestring1_points_x
andlinestring2_points_x
be combined into a single array of x-coordinates? This would simplify the interface, but what I'm wondering is whether this would be easier or harder for users?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limit is that the largest number of points both set can have in total is less than
std::numeric_limit<size_type>::max()
. This is more restrictive than having separate set of point vectors.cc. @zhangjianting with usage question.