C++ pairwise linestring distance #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
isVoid
added
2 - In Progress
|
What is the difference between a linestring and a polyline? |
…ture/linestring_distance_benchmark
harrism
approved these changes
May 3, 2022
trxcllnt
reviewed
May 5, 2022
trxcllnt
reviewed
May 5, 2022
trxcllnt
requested changes
May 5, 2022
vyasr
reviewed
May 5, 2022
There was a problem hiding this comment.
I'm getting notifications on this thread after commenting, and I've been seeing more cuspatial activity lately so I figured I'd give this a brief review to get a sense for some of the code structure. Most of my comments are probably microoptimizations, nothing blocking.
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
trxcllnt
approved these changes
May 10, 2022
|
I think we just need @vyasr to approve. |
vyasr
approved these changes
May 12, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
This PR introduces python bindings for pairwise linestring distance. Depends on #510 and has lots of commits from that PR. Should reduce once #510 merges. Authors: - Michael Wang (https://github.com/isVoid) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Mark Harris (https://github.com/harrism) URL: #521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #231 , computes distances between pairs of linestrings.