[FEA] polyline -> linestring?

[isVoid]

In general, polyline and linestring both refers to a data structure that contains multiple points with the line segments that connect the points. Linestring is standardized in GIS systems through OGC-SFS and provides a lot more relevant search results in google search as compared to search with polyline.

After introduction of #510 there will be two different names of the same concept. I would propose naming polyline with linestring in the code base to avoid confusion.

[harrism]

Did "polyline" already exist in the codebase?

[isVoid]

Yes, in cpp:

cuspatial/cpp/src/spatial/polyline_bounding_box.cu

Line 57 in 8c31c2c

std::unique_ptr<cudf::table> compute_polyline_bounding_boxes(cudf::column_view const& poly_offsets,

cuspatial/cpp/include/cuspatial/spatial_join.hpp

Line 151 in 6a34c21

std::unique_ptr<cudf::table> quadtree_point_to_nearest_polyline(

in python:

cuspatial/python/cuspatial/cuspatial/core/gis.py

Line 305 in 92266b6

def polyline_bounding_boxes(poly_offsets, xs, ys, expansion_radius):

cuspatial/python/cuspatial/cuspatial/core/spatial_join.py

Line 160 in 92266b6

def quadtree_point_to_nearest_polyline(

[isVoid]

Linestring isn't the first time showing up in the code base either:

cuspatial/python/cuspatial/cuspatial/io/geopandas_adapter.py

Line 59 in 92266b6

elif isinstance(geometry, LineString):

[github-actions]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

[thomcom]

I support this renaming. I think polyline is possibly older, and has moved toward linestring. Primarily I'm pretty sure it just heralds from a slightly different GIS community than ours. Linestring it is, for me.

[github-actions]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.