Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globally replace "polyline" with "linestring" #788

Merged
merged 12 commits into from
Nov 9, 2022
Merged

Globally replace "polyline" with "linestring" #788

merged 12 commits into from
Nov 9, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Nov 8, 2022

Description

Replaces all uses of "polyline" (and abbreviations) globally in cuspatial with "linestring" for consistency.

Fixes #520

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested review from a team as code owners November 8, 2022 06:20
@harrism harrism requested review from vyasr and jrhemstad November 8, 2022 06:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Nov 8, 2022
@harrism harrism requested review from isVoid and thomcom and removed request for jrhemstad and vyasr November 8, 2022 06:20
@harrism harrism added breaking Breaking change improvement Improvement / enhancement to an existing function c++ labels Nov 8, 2022
isVoid
isVoid approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

thomcom
thomcom previously requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking this on. I just noticed one filename that you missed.

cpp/src/join/quadtree_poly_filtering.cu Show resolved Hide resolved
@bdice bdice mentioned this pull request Nov 8, 2022
Merged
3 tasks
@harrism harrism dismissed thomcom’s stale review November 9, 2022 01:19

Satisfied and review was simple.

@harrism
Copy link
Member Author

harrism commented Nov 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 740b5b4 into rapidsai:branch-22.12 Nov 9, 2022
rapids-bot bot pushed a commit that referenced this pull request Nov 9, 2022
@bdice
Fix style checks. (#791)
337a92a 
Fixes issues seen in #788.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)
  - Ray Douglass (https://github.com/raydouglass)

URL: #791
@harrism harrism removed the c++ label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@thomcom thomcom thomcom left review comments

Assignees
No one assigned
Labels
breaking Breaking change cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] polyline -> linestring?
3 participants
@harrism @thomcom @isVoid