Fix GeoDataframe slicing issue by adding _slice_ method.
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcom
force-pushed
the
bug/slice-geodataframe-broken
branch
from
ecfd5ca to
329a08b
Compare
thomcom
added
bug
|
rerun tests |
thomcom
changed the title
GeoDataframe slicing issue by refactoring GeoColumnGeoDataframe slicing issue by adding _slice_ method.
isVoid
reviewed
Sep 21, 2022
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
…spatial into bug/slice-geodataframe-broken
|
Sure! I have done so in the latest commit. If you approve I'll merge soon. |
isVoid
approved these changes
Sep 23, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
This PR adds `docs/source/user_guide/index.ipynb`, a comprehensive description of the APIs available in cuspatial python and example code for each. The APIs are separated in a table of contents by the logical structure we've settled on for their location in the API. The demonstrate uses the `cuspatial.` version of every API, none are accessed using their full python package address. At the bottom I'm working on some examples of performing `contains` and `within`, DE-9IM operations that can be performed easily with `point-in-polygon`. Otherwise the document is complete. Depends on #685 and #680 This contributes to or closes #599 by providing an example use case of all python APIs. Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Mark Harris (https://github.com/harrism) - Michael Wang (https://github.com/isVoid) URL: #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will adds a
_slicemethod which is called when acudf.DataFrameis accessed in a variety of ways. It also adds thenamemember toGeoSeriesthat are pulled from theGeoDataFrame.Fixes #676
Checklist