-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Union-style indexing to .points
, .multipoints
, .lines
, and .polygons
GeoSeries
accessors
#685
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-22.10
from
thomcom:bug/make-geometry-buffers-sliceable
Sep 23, 2022
Merged
Add Union-style indexing to .points
, .multipoints
, .lines
, and .polygons
GeoSeries
accessors
#685
rapids-bot
merged 10 commits into
rapidsai:branch-22.10
from
thomcom:bug/make-geometry-buffers-sliceable
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcom
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
non-breaking
Non-breaking change
and removed
Python
Related to Python code
labels
Sep 21, 2022
isVoid
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
…com/cuspatial into bug/make-geometry-buffers-sliceable
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
This PR adds `docs/source/user_guide/index.ipynb`, a comprehensive description of the APIs available in cuspatial python and example code for each. The APIs are separated in a table of contents by the logical structure we've settled on for their location in the API. The demonstrate uses the `cuspatial.` version of every API, none are accessed using their full python package address. At the bottom I'm working on some examples of performing `contains` and `within`, DE-9IM operations that can be performed easily with `point-in-polygon`. Otherwise the document is complete. Depends on #685 and #680 This contributes to or closes #599 by providing an example use case of all python APIs. Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Mark Harris (https://github.com/harrism) - Michael Wang (https://github.com/isVoid) URL: #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
non-breaking
Non-breaking change
Python
Related to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
column._meta
object to slice the sub-geometry accessors named in the title so that.x
,.y
, and.xy
uses reflect any previous slicing that has occurred to theGeoSeries
.Fixes #683
Checklist