Refactor directed_hausdorff_distance and haversine_distance into GeoSeries Interface
#924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
requested review from
thomcom and
harrism
and removed request for
trxcllnt
3 tasks
harrism
changed the title
directed_hausdorff_distance and haversine_distance into GeoSeries Interfacedirected_hausdorff_distance and haversine_distance into GeoSeries Interface
harrism
approved these changes
Feb 14, 2023
thomcom
approved these changes
Feb 14, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
isVoid
added
feature request
thomcom
reviewed
Feb 14, 2023
thomcom
reviewed
Feb 14, 2023
3 tasks
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
Provides public GeoSeries methods to create single-type GeoSeries for linestrings and polygons in addition to the points and multipoints methods added in #924. Authors: - H. Thomson Comer (https://github.com/thomcom) - Michael Wang (https://github.com/isVoid) Approvers: - Michael Wang (https://github.com/isVoid) - Mark Harris (https://github.com/harrism) URL: #928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #921, closes #920
Also Fixes #917
This PR refactors all functions in
distance.pyto accept geoseries as input. It also adds two interfaces to GeoSeries:from_points_xyandfrom_multpoints_xy. Since geospatial data source can vary, these APIs ensures flexibility when constructing a geoseries.This PR also removes some stale demo files that uses these APIs.
Checklist