fix cuspatial.haversine_distance() example in multi-tenant notebook #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
cuspatial.haversine_distance()
example using the public NYC taxi data hosted on GSC (GSC console link).Running through the notebook code for that example (the same one that ends up at https://docs.rapids.ai/deployment/nightly/examples/rapids-autoscaling-multi-tenant-kubernetes/notebook/), I encountered 3 issues:
gcs://anaconda-public-data/nyc-taxi/2015.parquet
that are not actually parquet filescuspatial.haversine_distance()
expects to receive 2cuspatial.GeoSeries
objectsLooks like that changed here: rapidsai/cuspatial#924.
This resolves those issues.
How I tested this
Following the instructions from https://docs.rapids.ai/install#install-rapids, ran jupyter lab in a RAPIDS container like this:
Then ran this notebook code (just the
LocalCUDACluster
parts and below), on a machine with a few 80GB H100s. Confirmed that data was pulled successfully without needing to authenticate with GCP, and thatcuspatial.haversine_distance()
ran without error and produced plausible-looking results.