Skip to content

Commit

Permalink
Filter dd deprecation (#1312)
Browse files Browse the repository at this point in the history
Dask CUDA must use the deprecated `dask.dataframe` API until #1311 and rapidsai/cudf#15027 are both closed. This means that we must explicitly filter the following deprecation warning to avoid nighlty CI failures:

```
DeprecationWarning: The current Dask DataFrame implementation is deprecated. 
In a future release, Dask DataFrame will use new implementation that
contains several improvements including a logical query planning.
The user-facing DataFrame API will remain unchanged.

The new implementation is already available and can be enabled by
installing the dask-expr library:

    $ pip install dask-expr

and turning the query planning option on:

    >>> import dask
    >>> dask.config.set({'dataframe.query-planning': True})
    >>> import dask.dataframe as dd

API documentation for the new implementation is available at
https://docs.dask.org/en/stable/dask-expr-api.html

Any feedback can be reported on the Dask issue tracker
https://github.com/dask/dask/issues 

  import dask.dataframe as dd
```

This PR adds the (temporarily) necessary warning filter.

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1312
  • Loading branch information
rjzamora authored Feb 13, 2024
1 parent 0fb6d59 commit 21376a0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion dask_cuda/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
if sys.platform != "linux":
raise ImportError("Only Linux is supported by Dask-CUDA at this time")


import dask
import dask.utils
import dask.dataframe.core
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ filterwarnings = [
"error::FutureWarning",
# remove after https://github.com/rapidsai/dask-cuda/issues/1087 is closed
"ignore:There is no current event loop:DeprecationWarning:tornado",
# This warning must be filtered until dask-expr support
# is enabled in both dask-cudf and dask-cuda.
# See: https://github.com/rapidsai/dask-cuda/issues/1311
"ignore:Dask DataFrame implementation is deprecated:DeprecationWarning",
]

[tool.setuptools]
Expand Down

0 comments on commit 21376a0

Please sign in to comment.