Filter dd deprecation #1312
Merged
Filter dd deprecation #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
pentschev
reviewed
Feb 12, 2024
There was a problem hiding this comment.
@rjzamora this looks ok but I want to make sure of what's the intent here, do we want to filter this warning for all users or only tests? If the latter it may be more appropriate to add this in the pyproject.toml.
|
Good point @pentschev - I suppose it's probably best to constrain the filter to tests for now. I'll revise, thanks! |
pentschev
reviewed
Feb 12, 2024
| @@ -3,7 +3,6 @@ | |||
| if sys.platform != "linux": | |||
| raise ImportError("Only Linux is supported by Dask-CUDA at this time") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'm surprised linting didn't complain about this. It doesn't matter so let's keep it like this.
pentschev
approved these changes
Feb 12, 2024
|
Previous run passed, I merged the latest changes just in case. @rjzamora feel free to move this to "Ready for Review" and merging soon afterwards if there's nothing more in this PR. Thanks for working on it! |
rjzamora
added
5 - Ready to Merge
|
/merge |
younseojava
pushed a commit
to ROCm/dask-cuda-rocm
that referenced
this pull request
Apr 16, 2024
Dask CUDA must use the deprecated `dask.dataframe` API until rapidsai#1311 and rapidsai/cudf#15027 are both closed. This means that we must explicitly filter the following deprecation warning to avoid nighlty CI failures: ``` DeprecationWarning: The current Dask DataFrame implementation is deprecated. In a future release, Dask DataFrame will use new implementation that contains several improvements including a logical query planning. The user-facing DataFrame API will remain unchanged. The new implementation is already available and can be enabled by installing the dask-expr library: $ pip install dask-expr and turning the query planning option on: >>> import dask >>> dask.config.set({'dataframe.query-planning': True}) >>> import dask.dataframe as dd API documentation for the new implementation is available at https://docs.dask.org/en/stable/dask-expr-api.html Any feedback can be reported on the Dask issue tracker https://github.com/dask/dask/issues import dask.dataframe as dd ``` This PR adds the (temporarily) necessary warning filter. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) URL: rapidsai#1312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dask CUDA must use the deprecated
dask.dataframeAPI until #1311 and rapidsai/cudf#15027 are both closed. This means that we must explicitly filter the following deprecation warning to avoid nighlty CI failures:This PR adds the (temporarily) necessary warning filter.