handle more RAPIDS version formats in update-version.sh #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
jameslamb
added
improvement
pentschev
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
LGTM. Are we waiting for more changes here or is this good to merge @jameslamb ?
|
it's good to merge, thanks @pentschev ! |
raydouglass
approved these changes
Jan 29, 2024
|
Thanks @jameslamb ! |
|
/merge |
younseojava
pushed a commit
to ROCm/dask-cuda-rocm
that referenced
this pull request
Apr 16, 2024
Contributes to rapidsai/build-planning#13. Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`. This project doesn't appear to have any of those right now, but might in the future. ### How I tested this The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment). In this repo, I ran the following: ```shell ./ci/release/update-version.sh '23.10.00' git diff ./ci/release/update-version.sh '24.04.00' git diff ``` Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#1307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#13.
Updates
update-version.shto correctly handle RAPIDS dependencies likecudf-cu12==24.2.*.This project doesn't appear to have any of those right now, but might in the future.
How I tested this
The portability of this updated
sedcommand was tested here: rapidsai/cudf#14825 (comment).In this repo, I ran the following:
Confirmed that that first
git diffchanged all the things I expected, and that second one showed 0 changes.