Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure update-versions.sh scripts account for dependencies with -cu{CUDA_MAJOR} suffixes #13

Closed
jameslamb opened this issue Jan 22, 2024 · 2 comments
Closed

ensure update-versions.sh scripts account for dependencies with -cu{CUDA_MAJOR} suffixes #13

jameslamb opened this issue Jan 22, 2024 · 2 comments
Assignees
@jameslamb

Comments

@jameslamb
Copy link
Member

Overview

RAPIDS projects are released on the same cadence, mostly using the same versioning scheme, as described in https://docs.rapids.ai/releases/process/.

Given that, the projects tend to have dependencies on other RAPIDS projects from the same release. For example, like this in a pyproject.toml:

[project]
# ...
dependencies = [
    "cudf==24.2.*",
    # ...
    "dask-cuda==24.2.*",
    "dask-cudf==24.2.*",
    # ...
    "pylibraft==24.2.*",
    "raft-dask==24.2.*",
    "rapids-dask-dependency==24.2.*",
    "rmm==24.2.*"
]

(cuml code link).

When cutting a new release, shell scripts in each repo (by convention, ci/release/update-version.sh) are used to update all such versions to the newest RAPIDS release.

As of this writing, some of those scripts don't account for projects whose names have a -cu{CUDA_MAJOR} suffix in the name, like this:

cudf-cu12==24.2.*

As a result, some dependencies may be missed when beginning a new release cycle.

That should be fixed.

Approach

  1. review the discussion in Fix 24.04 versions cudf#14825 and update RAPIDS dependencies to 24.4, refactor dependencies.yaml cuml#5726
  2. make similar changes on the branch-24.04 branches of all other RAPIDS repos
@jameslamb jameslamb self-assigned this Jan 22, 2024
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
@jameslamb
Copy link
Member Author

jameslamb commented Jan 22, 2024 •
edited
Loading

Started on this today. I'll update this comment tomorrow when I get to the rest of the repos.

The following don't need changes, as they don't have other RAPIDS calVer projects in any of the files touched by update-version.sh.

  • cucim
  • rapids-cmake
  • rmm

PRs up for these:

This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Jan 25, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh, refactor dep…
ed7c281 
…endencies.yaml (#174)

Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This also pulls in some dependency refactoring originally added in #161, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '0.36.00'
git diff

./ci/release/update-version.sh '0.37.00
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - https://github.com/jakirkham

URL: #174
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue Jan 25, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh, refactor dep…
5e0cb36 
…endencies.yaml (#1329)

Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This also pulls in some dependency refactoring originally added in #1320, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1329
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Jan 30, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh (#1017)
12be765 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '0.36.00'
git diff

./ci/release/update-version.sh '0.37.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1017
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Jan 30, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh (#1307)
2adc059 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This project doesn't appear to have any of those right now, but might in the future.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1307
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue Feb 5, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh (#122)
dca9fd6 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`. This project doesn't appear to have any of those right now, but might in the future.

Also removes some references to Sphinx `conf.py` files in `update-version.sh`... this repo doesn't have those.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #122
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this issue Feb 5, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh (#566)
8c4c3fc 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This project doesn't appear to have any of those right now, but might in the future.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #566
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Feb 5, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh (#331)
047ec3e 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This project doesn't appear to have any of those right now, but might in the future.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #331
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Feb 8, 2024
@jameslamb
handle more RAPIDS version formats in update-version.sh, refactor dep…
9ad7389 
…endencies.yaml (#4109)

Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This also pulls in some dependency refactoring originally added in #4088, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Brad Rees (https://github.com/BradReesWork)
  - Ray Douglass (https://github.com/raydouglass)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)
  - Brad Rees (https://github.com/BradReesWork)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4109
@jameslamb
Copy link
Member Author

Thanks to @bdice 's work on rapidsai/cugraph#4109 (and all of them, to be honest) this is now complete 😁

younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this issue Apr 16, 2024
@jameslamb @younseojava
handle more RAPIDS version formats in update-version.sh (rapidsai#1307)
d35e711 
Contributes to rapidsai/build-planning#13.

Updates `update-version.sh` to correctly handle RAPIDS dependencies like `cudf-cu12==24.2.*`.

This project doesn't appear to have any of those right now, but might in the future.

### How I tested this

The portability of this updated `sed` command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

```shell
./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff
```

Confirmed that that first `git diff` changed all the things I expected, and that second one showed 0 changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameslamb jameslamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameslamb