-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update condaforge/miniforge3 #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as it looks like the checks have re-run and some now fail.
Issue seems to be that you're changing python version in an already-built environment. That's very fragile. Here, there's a library that was introduced with python 3.10,
There are several ways around this:
|
18a5b2b
to
268a820
Compare
Latest code changes adjust the Dockerfile for the raft-ann cpu benchmark, using micromamba to populate the environment in /opt/conda. Relative to using the miniforge3 docker image, this approach avoids changing python version in an already created environment, which was the cause of the conflict issue. |
a572d9c
to
dd6623c
Compare
@raydouglass the builds are all working now, but there's a failing test in the How should we handle this? Try to fix that notebook issue in a separate PR (maybe separate repo?) and then re-run the failed jobs here? |
I can't tell if it's the exact same error, but the same notebook has an open issue: rapidsai/cuspatial#1426. Since it's unlikely to be related to the docker image itself, I think we can merge this PR and the notebook issue will be resolved in |
Looks like there's a conflict |
This is currently targeting |
This PR will be obsolete when #715 is merged. We updated the base miniforge image tag there. |
Added a closes note in that PR so that when it is merged it will automatically close this one |
Update to match rapidsai/miniforge-cuda#62
Supersedes #643