Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update condaforge/miniforge3 #660

Closed
wants to merge 10 commits into from
Closed

Conversation

raydouglass
Copy link
Member

Update to match rapidsai/miniforge-cuda#62

Supersedes #643

@raydouglass raydouglass requested a review from a team as a code owner April 19, 2024 18:02
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as it looks like the checks have re-run and some now fail.

@raydouglass raydouglass changed the base branch from branch-24.06 to branch-24.08 June 14, 2024 19:35
@raydouglass raydouglass requested a review from a team as a code owner June 14, 2024 19:35
@msarahan
Copy link

Issue seems to be that you're changing python version in an already-built environment. That's very fragile. Here, there's a library that was introduced with python 3.10, truststore. Python 3.9 doesn't actually need it, but because it is already in the environment, mamba does not know that it can get rid of it:

15.38 The following packages are incompatible
15.38 ├─ python 3.9**  is requested and can be installed;
15.38 └─ truststore is not installable because it requires
15.38    └─ python >=3.10  but there are no viable options
15.38       ├─ python [3.10.0|3.10.1|...|3.12.3] conflicts with any installable versions previously reported;
15.38       └─ python 3.12.0rc3 would require
15.38          └─ _python_rc, which does not exist (perhaps a missing channel).

There are several ways around this:

  1. Create a new environment instead of modifying base
  2. Create a base miniforge install that has an older python in the base environment
  3. create multiple miniforge images, one for each python version that we use
  4. probably other ways too, if none of these are palatable

@jakirkham jakirkham changed the base branch from branch-24.08 to branch-24.10 July 30, 2024 21:31
@msarahan msarahan self-assigned this Jul 31, 2024
@msarahan
Copy link

Latest code changes adjust the Dockerfile for the raft-ann cpu benchmark, using micromamba to populate the environment in /opt/conda.

Relative to using the miniforge3 docker image, this approach avoids changing python version in an already created environment, which was the cause of the conflict issue.

@msarahan
Copy link

msarahan commented Aug 2, 2024

@raydouglass the builds are all working now, but there's a failing test in the cuspatial/ZipCodes_Stops_PiP_cuSpatial.ipynb notebook. It's hard to decode the traceback from all the markup stuff, but it seems like it might be related to cudf. https://github.com/rapidsai/docker/actions/runs/10207287173/job/28242755845?pr=660#step:9:169

How should we handle this? Try to fix that notebook issue in a separate PR (maybe separate repo?) and then re-run the failed jobs here?

@raydouglass
Copy link
Member Author

How should we handle this? Try to fix that notebook issue in a separate PR (maybe separate repo?) and then re-run the failed jobs here?

I can't tell if it's the exact same error, but the same notebook has an open issue: rapidsai/cuspatial#1426.

Since it's unlikely to be related to the docker image itself, I think we can merge this PR and the notebook issue will be resolved in cuspatial.

@raydouglass
Copy link
Member Author

Just realized I cannot approve since I opened this PR originally. But would be good to get a review from @dantegd and @AyodeAwe maybe.

@AyodeAwe
Copy link
Contributor

Looks like there's a conflict

@jakirkham
Copy link
Member

This is currently targeting branch-24.10. Should this move to branch-24.12?

@bdice
Copy link
Contributor

bdice commented Oct 22, 2024

This PR will be obsolete when #715 is merged. We updated the base miniforge image tag there.

@jakirkham
Copy link
Member

Added a closes note in that PR so that when it is merged it will automatically close this one

@rapids-bot rapids-bot bot closed this in #715 Nov 6, 2024
@rapids-bot rapids-bot bot closed this in e6ca130 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants