Rename raft-ann-bench to cuvs-bench and update to use the current cuvs-bench package #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
approved these changes
Oct 17, 2024
bdice
reviewed
Oct 17, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
reviewed
Oct 17, 2024
bdice
reviewed
Oct 17, 2024
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Oct 18, 2024
This attempts to rename `cuvs_bench` to `cuvs-bench` and similarly for the CPU package. This follows from this thread: rapidsai/docker#715 (comment) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) - Dante Gama Dessavre (https://github.com/dantegd) URL: #417
bdice
reviewed
Oct 18, 2024
dantegd
changed the title
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Oct 22, 2024
|
I pushed one small fix that was missed -- now things look good. Thanks for the iterations on this! |
bdice
reviewed
Oct 22, 2024
|
Oops. Looks like one conversation was unaddressed, but I don't want to block on it. #715 (comment) edit: handled in 8a4ccce |
bdice
reviewed
Oct 22, 2024
raydouglass
approved these changes
Oct 29, 2024
|
@raydouglass anything else needed here or can this be merged and containers published? |
|
And after this is merged, can we stop building and/or remove raft’s benchmark packages? |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR renames the
raft-ann-benchtocuvs-benchand updates the run scripts so that we use the cuVS bench package as opposed to RAFT, alongside small updates needed in the calls.Closes #660